From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: Fabio Coatti <fabio.coatti@gmail.com>,
Stephane Eranian <eranian@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"Yan, Zheng" <zheng.z.yan@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: WARNING: CPU: 2 PID: 1 at arch/x86/mm/ioremap.c:171 __ioremap_caller+0x290/0x2fa()
Date: Tue, 15 Jul 2014 16:54:46 -0700 [thread overview]
Message-ID: <53C5BF46.3070604@zytor.com> (raw)
In-Reply-To: <CAE9FiQVN1WLigYt7YGHsd1f+BreApubYbjC9j9tzrCe-p5f=HA@mail.gmail.com>
On 07/15/2014 04:40 PM, Yinghai Lu wrote:
>>
>> One of the reasons for iomem_resource is so we don't hand out the same
>> address space to two different devices. We *could* do that by keeping
>> track of the union of all devices and reserved areas that we know
>> about.
>>
>> But the current resource code is more strict: it enforces a hierarchy.
>> For example, in this case, it rejects the 00:00 PNP resource because
>> it is larger than the e820 entry. The problem with rejecting it is
>> that we might hand out [mem 0xfed14000-0xfed17fff] to another device
>> even though PNP told us that it's in use.
>>
>> I'm about to head out for a few weeks of vacation, so I won't be able
>> to do anything with this.
>
> In that case, we could reserve the whole MCH range in e820 from
> trim_snb_memory() instead.
>
> HPA, what is your idea about it?
>
> Yinghai
>
We could quirk it, but we would have to make bloody darn sure that we
don't break any systems because of unusual configuration and so on.
I agree that we need to treat fixed resources as equivalent to reserved.
This is also a BIOS bug (it should reserve the whole region), but that
happens far too frequently. I don't know if we have any way to do that
without massive surgery to the current code, though.
-hpa
next prev parent reply other threads:[~2014-07-15 23:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADpTngUm7d88RJS9OV=64t6QrJU4r3M_Z8eV1QYWPeeB5SX5-w@mail.gmail.com>
2014-07-07 20:47 ` WARNING: CPU: 2 PID: 1 at arch/x86/mm/ioremap.c:171 __ioremap_caller+0x290/0x2fa() Greg Kroah-Hartman
2014-07-07 20:51 ` Fabio Coatti
2014-07-09 18:41 ` Fabio Coatti
2014-07-09 18:54 ` Greg Kroah-Hartman
2014-07-09 19:48 ` Fabio Coatti
2014-07-10 8:44 ` Peter Zijlstra
2014-07-10 8:52 ` Peter Zijlstra
2014-07-10 8:54 ` Peter Zijlstra
2014-07-10 12:13 ` Fabio Coatti
2014-07-10 19:12 ` Stephane Eranian
2014-07-10 20:05 ` Bjorn Helgaas
2014-07-11 7:38 ` Fabio Coatti
2014-07-11 18:11 ` Bjorn Helgaas
2014-07-15 20:33 ` Bjorn Helgaas
2014-07-15 23:40 ` Yinghai Lu
2014-07-15 23:54 ` H. Peter Anvin [this message]
2014-07-16 0:56 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C5BF46.3070604@zytor.com \
--to=hpa@zytor.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=eranian@google.com \
--cc=fabio.coatti@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=yinghai@kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.