From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [PATCH 1/6] tty: serial: 8250 core: provide a function to export uart_8250_port Date: Wed, 16 Jul 2014 10:22:26 +0200 Message-ID: <53C63642.7080208@linutronix.de> References: <1404928177-26554-1-git-send-email-bigeasy@linutronix.de> <1404928177-26554-2-git-send-email-bigeasy@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-serial-owner@vger.kernel.org To: Olivier Galibert Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren , Felipe Balbi , Linux Kernel Mailing List , linux-serial@vger.kernel.org List-Id: linux-omap@vger.kernel.org On 07/10/2014 04:30 PM, Olivier Galibert wrote: > On Wed, Jul 9, 2014 at 7:49 PM, Sebastian Andrzej Siewior > wrote: >> + * The lock assumption made here is none because runtime-pm suspend/resume >> + * callbacks should not be invoked there is any operation performed on the port. > > I think there's a missing "if"? Thanks, fixed up. > Best, > > OG. > Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: bigeasy@linutronix.de (Sebastian Andrzej Siewior) Date: Wed, 16 Jul 2014 10:22:26 +0200 Subject: [PATCH 1/6] tty: serial: 8250 core: provide a function to export uart_8250_port In-Reply-To: References: <1404928177-26554-1-git-send-email-bigeasy@linutronix.de> <1404928177-26554-2-git-send-email-bigeasy@linutronix.de> Message-ID: <53C63642.7080208@linutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/10/2014 04:30 PM, Olivier Galibert wrote: > On Wed, Jul 9, 2014 at 7:49 PM, Sebastian Andrzej Siewior > wrote: >> + * The lock assumption made here is none because runtime-pm suspend/resume >> + * callbacks should not be invoked there is any operation performed on the port. > > I think there's a missing "if"? Thanks, fixed up. > Best, > > OG. > Sebastian