From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: pramod.gurav.etc@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Josh Cartwright <joshc@codeaurora.org>,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected
Date: Wed, 16 Jul 2014 15:07:07 +0300 [thread overview]
Message-ID: <53C66AEB.7030906@mm-sol.com> (raw)
In-Reply-To: <1405510797-755-1-git-send-email-pramod.gurav.etc@gmail.com>
Hi,
<snip>
>
> Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
> CC: Josh Cartwright <joshc@codeaurora.org>
> CC: Mark Brown <broonie@linaro.org>
> ---
> This was found when I enabled support for Qualcomm QPNP PMICs and was
> compiling it. It selects REGMAP_SPMI and hence the crash.
>
> drivers/base/regmap/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> index 4251570..1aa9d71 100644
> --- a/drivers/base/regmap/Kconfig
> +++ b/drivers/base/regmap/Kconfig
> @@ -16,6 +16,7 @@ config REGMAP_SPI
> tristate
>
> config REGMAP_SPMI
> + select SPMI
NO, IMO the CONFIG_SPMI should be enabled by qcom_defconfig and
multi_v7_defconfig. See CONFIG_I2C and REGMAP_I2C for example.
--
regards,
Stan
next prev parent reply other threads:[~2014-07-16 12:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 11:39 [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected pramod.gurav.etc
2014-07-16 12:07 ` Stanimir Varbanov [this message]
2014-07-16 12:14 ` Pramod Gurav
2014-07-16 12:25 ` Stanimir Varbanov
2014-07-16 12:56 ` Pramod Gurav
2014-07-16 13:53 ` Stanimir Varbanov
2014-07-16 13:53 ` Mark Brown
2014-07-16 14:00 ` Ivan T. Ivanov
2014-07-16 14:18 ` Mark Brown
2014-07-16 14:42 ` pramod gurav
2014-07-16 14:48 ` Mark Brown
2014-07-16 12:19 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C66AEB.7030906@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=broonie@linaro.org \
--cc=joshc@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pramod.gurav.etc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.