From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected Date: Wed, 16 Jul 2014 14:19:47 +0200 Message-ID: <53C66DE3.5080502@metafoo.de> References: <1405510797-755-1-git-send-email-pramod.gurav.etc@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1405510797-755-1-git-send-email-pramod.gurav.etc@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: pramod.gurav.etc@gmail.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Josh Cartwright , Mark Brown List-Id: linux-arm-msm@vger.kernel.org On 07/16/2014 01:39 PM, pramod.gurav.etc@gmail.com wrote: > From: Pramod Gurav > > REGMAP_SPMI module calls some functions from SPMI hence build breaks > when SPMI is not enabled while compiling REGMAP_SPMI with below linker > errors: > > drivers/built-in.o: In function `regmap_spmi_ext_read': > :(.text+0x1143ec): undefined reference to `spmi_ext_register_read' > :(.text+0x11443c): undefined reference to `spmi_ext_register_readl' > drivers/built-in.o: In function `regmap_spmi_ext_gather_write': > :(.text+0x1144c4): undefined reference to `spmi_ext_register_write' > :(.text+0x114520): undefined reference to `spmi_ext_register_writel' > drivers/built-in.o: In function `regmap_spmi_base_read': > :(.text+0x1145b8): undefined reference to `spmi_register_read' > drivers/built-in.o: In function `regmap_spmi_base_gather_write': > :(.text+0x114630): undefined reference to `spmi_register_write' > :(.text+0x11465c): undefined reference to `spmi_register_zero_write' > > Signed-off-by: Pramod Gurav > CC: Josh Cartwright > CC: Mark Brown > --- > This was found when I enabled support for Qualcomm QPNP PMICs and was > compiling it. It selects REGMAP_SPMI and hence the crash. Any driver that does select REGMAP_SPMI needs to depends on SPMI. So the correct fix for this issue is to make sure that the driver can only be enabled if SPMI is enabled. - Lars