From: Daniel Thompson <daniel.thompson@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, patches@linaro.org,
linaro-kernel@lists.linaro.org, Greg Ungerer <gerg@uclinux.org>,
Arnd Bergmann <arnd.bergmann@linaro.org>
Subject: Re: [PATCH] arm: ks8695: Migrate debug_ll macros to shared directory
Date: Wed, 16 Jul 2014 13:28:48 +0100 [thread overview]
Message-ID: <53C67000.3090203@linaro.org> (raw)
In-Reply-To: <5177050.SNdzuaeUpQ@wuerfel>
On 16/07/14 12:11, Arnd Bergmann wrote:
> On Wednesday 16 July 2014 11:31:07 Daniel Thompson wrote:
>> As part of the migration a couple of uart definitions have been copied
>> from of the platform specific header files.
>>
>> Note that, in order to keep oldconfig working nicely we must defer the
>> removal of arch/arm/mach-ks8695/include/mach/debug-macro.S until
>> DEBUG_LL_UART_NONE has been removed.
>>
>> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
>> Cc: Russell King <linux@arm.linux.org.uk>
>> Cc: Greg Ungerer <gerg@uclinux.org>
>> Cc: Arnd Bergmann <arnd.bergmann@linaro.org>
>> ---
>>
>> Notes:
>> This is a contribution towards the removal of DEBUG_LL_UART_NONE, see
>> http://thread.gmane.org/gmane.linux.kernel/1712068/focus=1746065 for
>> details.
>>
>> arch/arm/Kconfig.debug | 8 ++++++++
>> arch/arm/include/debug/ks8695.S | 40 ++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 48 insertions(+)
>> create mode 100644 arch/arm/include/debug/ks8695.S
>>
> The change looks good, but it seems you forgot to remove
> arch/arm/mach-ks8695/include/mach/debug-macro.S.
I explained why I didn't delete this file in the changelog.
If this patch were applied whilst DEBUG_LL_UART_NONE still exists then
there are problems with oldconfig builds failing to compile (for the
same reason as the versatile stuff).
> When you add that, also remember to use 'git format-patch -M' to show the
> changes you did rather than one file added and one removed.
I hope at some point soon(ish) to have a patch series that moves all
four platforms across and trashes DEBUG_LL_UART_NONE. I'll respin this
patch as part of that (with the deleted file).
next prev parent reply other threads:[~2014-07-16 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 10:31 [PATCH] arm: ks8695: Migrate debug_ll macros to shared directory Daniel Thompson
2014-07-16 10:36 ` Daniel Thompson
2014-07-16 11:11 ` Arnd Bergmann
2014-07-16 12:28 ` Daniel Thompson [this message]
2014-07-16 12:35 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C67000.3090203@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=arnd.bergmann@linaro.org \
--cc=arnd@arndb.de \
--cc=gerg@uclinux.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.