From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 1/2] xen/arm: Divide GIC initialization
	in 2 parts
Date: Wed, 16 Jul 2014 15:22:45 +0100
Message-ID: <53C68AB5.7030203@linaro.org>
References: <1404912223-9320-1-git-send-email-julien.grall@linaro.org>
	<1405516256.15219.4.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1X7Q6d-0000jY-Je
	for xen-devel@lists.xenproject.org; Wed, 16 Jul 2014 14:22:51 +0000
Received: by mail-wg0-f51.google.com with SMTP id b13so1006698wgh.22
	for <xen-devel@lists.xenproject.org>;
	Wed, 16 Jul 2014 07:22:50 -0700 (PDT)
In-Reply-To: <1405516256.15219.4.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 16/07/14 14:10, Ian Campbell wrote:
> On Wed, 2014-07-09 at 14:23 +0100, Julien Grall wrote:
>> Currently the function to translate IRQ from the device tree is set
>> unconditionally  to be able to be able to retrieve serial/timer IRQ before the
>> GIC has been initialized.
>>
>> It assumes that the xlate function won't never changed. We may also need to
>
> "won't ever change".
>
>> @@ -560,8 +561,11 @@ static hw_irq_controller gicv2_guest_irq_type = {
>>       .set_affinity = gicv2_irq_set_affinity,
>>   };
>>
>> +static int __init gicv2_init(void);
>
> I think you can reorder things to
> 	gic_init() { }
> 	ops
> 	gic_preinit()
> to avoid the forward declaration.

I wanted to move the less possible code. I will reorder it in the next 
series.

>> @@ -261,11 +265,15 @@ struct gic_info {
>>       uint8_t nr_lrs;
>>       /* Maintenance irq number */
>>       unsigned int maintenance_irq;
>> +    /* Pointer to the device tree node representing the interrupt controller */
>> +    const struct dt_device_node *node;
>
> You added this to both struct gic_info and gicv2_info?

I guess you wanted to say gicv2 instead of gicv2_info?

The one in gicv2 is an error, I will drop it.

Regards,

-- 
Julien Grall