From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 2/2] xen/dt: Allow only IRQ translation that are mapped to main GIC Date: Wed, 16 Jul 2014 15:36:34 +0100 Message-ID: <53C68DF2.3070600@linaro.org> References: <1404912223-9320-1-git-send-email-julien.grall@linaro.org> <1404912223-9320-2-git-send-email-julien.grall@linaro.org> <1405516449.15219.7.camel@kazak.uk.xensource.com> <53C68C14.6000702@linaro.org> <1405521255.16617.46.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X7QK1-0002IM-2P for xen-devel@lists.xenproject.org; Wed, 16 Jul 2014 14:36:41 +0000 Received: by mail-wi0-f177.google.com with SMTP id ho1so1458395wib.4 for ; Wed, 16 Jul 2014 07:36:39 -0700 (PDT) In-Reply-To: <1405521255.16617.46.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 16/07/14 15:34, Ian Campbell wrote: > On Wed, 2014-07-16 at 15:28 +0100, Julien Grall wrote: >>>> - /* TODO: Retrieve the right irq_xlate. This is only work for the gic */ >>>> + if ( raw->controller != dt_interrupt_controller ) >>>> + return -EINVAL; >>>> >>>> + /* TODO: Retrieve the right irq_xlate. This is only work for the gic */ >>> >>> "This only works for ...". >>> >>> Do you mean it to say "primary gic"? In which case I think it was in the >>> correct location before (i.e. before the check which enforced that). >> >> Which location are you talking about? The one in map_device? > > I meant the place from where it is removed by this patch. I was trying > to say that the correct form would be (modulo the long line): > > /* TODO: Retrieve the right irq_xlate. This only works for the primary gic */ > if ( raw->controller != dt_interrupt_controller ) > return -EINVAL; > > return dt_...xlat(...) > > i.e. the comment belongs with the check. Oh ok. I will it before the check. Regards, -- Julien Grall