From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 04/19] serial: samsung: Remove support for legacy clock code Date: Wed, 16 Jul 2014 16:43:55 +0200 Message-ID: <53C68FAB.9070102@samsung.com> References: <1404496099-26708-1-git-send-email-t.figa@samsung.com> <1404496099-26708-5-git-send-email-t.figa@samsung.com> <1405502840.4408.2.camel@x220> <53C67386.5070401@samsung.com> <1405520767.4408.39.camel@x220> <1405521324.4408.44.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:48057 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933848AbaGPOof (ORCPT ); Wed, 16 Jul 2014 10:44:35 -0400 In-reply-to: <1405521324.4408.44.camel@x220> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Paul Bolle Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kukjin Kim , Arnd Bergmann , Olof Johansson , Marek Szyprowski , Mark Brown , =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , Tomasz Figa On 16.07.2014 16:35, Paul Bolle wrote: > On Wed, 2014-07-16 at 16:26 +0200, Paul Bolle wrote: >> On Wed, 2014-07-16 at 14:43 +0200, Tomasz Figa wrote: >>> That's right. Apparently I missed them. I guess that's not critical, >>> though, and could be done in separate patch, right? >> >> This is not critical at all, so that's fine with me. > > Actually, that's only correct if the solution here is to just remove the > (currently) dead code hidden behind CONFIG_SAMSUNG_CLOCK. But if the > solution requires something less trivial, that might be quite wrong. > > So please disregard my comment! The code between those ifdefs is no longer used, because all Samsung platforms use the Common Clock Framework after this series. So I believe we can safely remove this dead code. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: t.figa@samsung.com (Tomasz Figa) Date: Wed, 16 Jul 2014 16:43:55 +0200 Subject: [PATCH 04/19] serial: samsung: Remove support for legacy clock code In-Reply-To: <1405521324.4408.44.camel@x220> References: <1404496099-26708-1-git-send-email-t.figa@samsung.com> <1404496099-26708-5-git-send-email-t.figa@samsung.com> <1405502840.4408.2.camel@x220> <53C67386.5070401@samsung.com> <1405520767.4408.39.camel@x220> <1405521324.4408.44.camel@x220> Message-ID: <53C68FAB.9070102@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16.07.2014 16:35, Paul Bolle wrote: > On Wed, 2014-07-16 at 16:26 +0200, Paul Bolle wrote: >> On Wed, 2014-07-16 at 14:43 +0200, Tomasz Figa wrote: >>> That's right. Apparently I missed them. I guess that's not critical, >>> though, and could be done in separate patch, right? >> >> This is not critical at all, so that's fine with me. > > Actually, that's only correct if the solution here is to just remove the > (currently) dead code hidden behind CONFIG_SAMSUNG_CLOCK. But if the > solution requires something less trivial, that might be quite wrong. > > So please disregard my comment! The code between those ifdefs is no longer used, because all Samsung platforms use the Common Clock Framework after this series. So I believe we can safely remove this dead code. Best regards, Tomasz