From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH/RFC v4 04/21] leds: Reorder include directives Date: Wed, 16 Jul 2014 18:42:36 +0300 Message-ID: <53C69D6C.3010705@iki.fi> References: <1405087464-13762-1-git-send-email-j.anaszewski@samsung.com> <1405087464-13762-5-git-send-email-j.anaszewski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1405087464-13762-5-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jacek Anaszewski , linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, Bryan Wu , Richard Purdie List-Id: linux-leds@vger.kernel.org Hi Jacek, Jacek Anaszewski wrote: > Reorder include directives so that they are arranged > in alphabetical order. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/led-class.c | 13 +++++++------ > drivers/leds/led-core.c | 3 ++- > include/linux/leds.h | 2 +- > 3 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c > index da79bbb..0127783 100644 > --- a/drivers/leds/led-class.c > +++ b/drivers/leds/led-class.c > @@ -9,16 +9,17 @@ > * published by the Free Software Foundation. > */ > > -#include > -#include > +#include > +#include > +#include > #include > +#include > +#include > #include > +#include > +#include Do you also need slab.h? > #include > -#include > #include > -#include > -#include > -#include > #include "leds.h" > > static struct class *leds_class; > diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c > index 0ac06ed..d156fb6 100644 > --- a/drivers/leds/led-core.c > +++ b/drivers/leds/led-core.c > @@ -12,10 +12,11 @@ > */ > > #include > +#include > #include > #include > +#include And mutex.h here? With that fixed, if there are some other patches that are essentially cleanups that could go in well before the rest of the set. Some of the patches will take a little longer, I presume. I'll let you know if/when there's an update regarding the compound controls patchset. -- Kind regards, Sakari Ailus e-mail: sakari.ailus-X3B1VOXEql0@public.gmane.org XMPP: sailus-PCDdDYkjdNMDXYZnReoRVg@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga03.intel.com ([143.182.124.21]:29120 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964915AbaGPPml (ORCPT ); Wed, 16 Jul 2014 11:42:41 -0400 Message-ID: <53C69D6C.3010705@iki.fi> Date: Wed, 16 Jul 2014 18:42:36 +0300 From: Sakari Ailus MIME-Version: 1.0 To: Jacek Anaszewski , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org CC: kyungmin.park@samsung.com, b.zolnierkie@samsung.com, Bryan Wu , Richard Purdie Subject: Re: [PATCH/RFC v4 04/21] leds: Reorder include directives References: <1405087464-13762-1-git-send-email-j.anaszewski@samsung.com> <1405087464-13762-5-git-send-email-j.anaszewski@samsung.com> In-Reply-To: <1405087464-13762-5-git-send-email-j.anaszewski@samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Jacek, Jacek Anaszewski wrote: > Reorder include directives so that they are arranged > in alphabetical order. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/led-class.c | 13 +++++++------ > drivers/leds/led-core.c | 3 ++- > include/linux/leds.h | 2 +- > 3 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c > index da79bbb..0127783 100644 > --- a/drivers/leds/led-class.c > +++ b/drivers/leds/led-class.c > @@ -9,16 +9,17 @@ > * published by the Free Software Foundation. > */ > > -#include > -#include > +#include > +#include > +#include > #include > +#include > +#include > #include > +#include > +#include Do you also need slab.h? > #include > -#include > #include > -#include > -#include > -#include > #include "leds.h" > > static struct class *leds_class; > diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c > index 0ac06ed..d156fb6 100644 > --- a/drivers/leds/led-core.c > +++ b/drivers/leds/led-core.c > @@ -12,10 +12,11 @@ > */ > > #include > +#include > #include > #include > +#include And mutex.h here? With that fixed, if there are some other patches that are essentially cleanups that could go in well before the rest of the set. Some of the patches will take a little longer, I presume. I'll let you know if/when there's an update regarding the compound controls patchset. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk