From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH/RFC v4 05/21] leds: avoid using deprecated DEVICE_ATTR macro Date: Wed, 16 Jul 2014 18:46:44 +0300 Message-ID: <53C69E64.4030801@iki.fi> References: <1405087464-13762-1-git-send-email-j.anaszewski@samsung.com> <1405087464-13762-6-git-send-email-j.anaszewski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1405087464-13762-6-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jacek Anaszewski , linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, Bryan Wu , Richard Purdie List-Id: linux-leds@vger.kernel.org Hi Jacek, Jacek Anaszewski wrote: > Make the sysfs attributes definition consistent in the whole file. > The modification entails change of the function name: > led_max_brightness_show -> max_brightness_show I'm not sure whether DEVICE_ATTR() is really deprecated but nevertheless this is cleaner. Acked-by: Sakari Ailus -- Kind regards, Sakari Ailus e-mail: sakari.ailus-X3B1VOXEql0@public.gmane.org XMPP: sailus-PCDdDYkjdNMDXYZnReoRVg@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga01.intel.com ([192.55.52.88]:22922 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964942AbaGPPrd (ORCPT ); Wed, 16 Jul 2014 11:47:33 -0400 Message-ID: <53C69E64.4030801@iki.fi> Date: Wed, 16 Jul 2014 18:46:44 +0300 From: Sakari Ailus MIME-Version: 1.0 To: Jacek Anaszewski , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org CC: kyungmin.park@samsung.com, b.zolnierkie@samsung.com, Bryan Wu , Richard Purdie Subject: Re: [PATCH/RFC v4 05/21] leds: avoid using deprecated DEVICE_ATTR macro References: <1405087464-13762-1-git-send-email-j.anaszewski@samsung.com> <1405087464-13762-6-git-send-email-j.anaszewski@samsung.com> In-Reply-To: <1405087464-13762-6-git-send-email-j.anaszewski@samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Jacek, Jacek Anaszewski wrote: > Make the sysfs attributes definition consistent in the whole file. > The modification entails change of the function name: > led_max_brightness_show -> max_brightness_show I'm not sure whether DEVICE_ATTR() is really deprecated but nevertheless this is cleaner. Acked-by: Sakari Ailus -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk