From: Eric Sandeen <sandeen@sandeen.net>
To: Jeff Liu <jeff.liu@oracle.com>, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota
Date: Wed, 16 Jul 2014 12:10:42 -0500 [thread overview]
Message-ID: <53C6B212.9030704@sandeen.net> (raw)
In-Reply-To: <53C4F5DB.2060108@oracle.com>
On 7/15/14, 4:35 AM, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> We are intended to check up uflags against FS_PROJ_QUOTA rather than
> FS_USER_UQUOTA once more, it looks to me like a typo, but might cause
> the project quota metadata space can not be removed.
Ugh, mea culpa. Thanks for spotting. :(
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Thankfully I don't think anyone uses this interface ;)
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ---
> fs/xfs/xfs_quotaops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
> index 4f7aecb..b238027 100644
> --- a/fs/xfs/xfs_quotaops.c
> +++ b/fs/xfs/xfs_quotaops.c
> @@ -123,7 +123,7 @@ xfs_fs_rm_xquota(
> flags |= XFS_DQ_USER;
> if (uflags & FS_GROUP_QUOTA)
> flags |= XFS_DQ_GROUP;
> - if (uflags & FS_USER_QUOTA)
> + if (uflags & FS_PROJ_QUOTA)
> flags |= XFS_DQ_PROJ;
>
> return xfs_qm_scall_trunc_qfiles(mp, flags);
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-07-16 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 9:35 [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota Jeff Liu
2014-07-15 10:25 ` Christoph Hellwig
2014-07-16 7:11 ` Jeff Liu
2014-07-16 7:12 ` Christoph Hellwig
2014-07-16 8:32 ` Jeff Liu
2014-07-16 17:10 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C6B212.9030704@sandeen.net \
--to=sandeen@sandeen.net \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.