From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7SkG-0000cv-EX for qemu-devel@nongnu.org; Wed, 16 Jul 2014 13:12:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7Sk6-0006eG-NP for qemu-devel@nongnu.org; Wed, 16 Jul 2014 13:11:56 -0400 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=52682 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7Sk6-0006e4-GA for qemu-devel@nongnu.org; Wed, 16 Jul 2014 13:11:46 -0400 Message-ID: <53C6B24D.4020403@weilnetz.de> Date: Wed, 16 Jul 2014 19:11:41 +0200 From: Stefan Weil MIME-Version: 1.0 References: <20140716002632.23073.40357@loki> <53C6A816.9090306@weilnetz.de> <53C6AD18.8030102@redhat.com> In-Reply-To: <53C6AD18.8030102@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Michael Tokarev , =?UTF-8?B?QXVyw6lsaWVuIEphcm5v?= Cc: Paolo Bonzini , Peter Lieven , Peter Maydell Am 16.07.2014 18:49, schrieb Paolo Bonzini: > Il 16/07/2014 18:28, Stefan Weil ha scritto: >> Debian testing includes a brand new libiscsi, but it >> does not include libiscsi.pc, so pkg-config won't know that it is >> available and configure will disable libiscsi. >=20 > That's a packaging bug. CC'ing Michael as he is the Debian maintainer of this package and Aur=C3=A9lien who maintains QEMU for Debian. Michael, should I send a Debian bug report for libiscsi-dev? Would an update of libiscsi for Debian stable be reasonable if versions older than 1.9 are too buggy to be used? I must admit that I'm a little bit surprised because iSCSI support worked for me quite well the last time I used it with Debian wheezy. Regards Stefan >=20 >> I have a patch which >> fixes this, so QEMU for Debian testing could include libiscsi again. >> >> Is a feature regression like this one acceptable? Do we need additiona= l >> testing (maybe run the build bots with --enable-xxx, so builds fail wh= en >> xxx no longer works)? >=20 > As mentioned in the e49ab19fcaa617ad6cdfe1ac401327326b6a2552 commit > message, this was intentional. I was reluctant to do it, but ultimatel= y > Peter Lieven convinced me that it isn't just about using fancy new APIs= ; > libiscsi was too buggy to be useful until release 1.8.0 (even 1.9.0 > requires a patch to avoid segfaults, and many more if you want to run i= t > on ARM). >=20 > Paolo