From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [PATCH] drm/radeon: remove visible vram size limit on bo allocation Date: Wed, 16 Jul 2014 19:56:53 +0200 Message-ID: <53C6BCE5.30200@vodafone.de> References: <1405531594-25297-1-git-send-email-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id EE7316E0A0 for ; Wed, 16 Jul 2014 10:57:08 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by pegasos-out.vodafone.de (Rohrpostix1 Daemon) with ESMTP id 58DFE260824 for ; Wed, 16 Jul 2014 19:57:07 +0200 (CEST) Received: from pegasos-out.vodafone.de ([127.0.0.1]) by localhost (rohrpostix1.prod.vfnet.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jg9a-ZstLI9G for ; Wed, 16 Jul 2014 19:57:01 +0200 (CEST) In-Reply-To: <1405531594-25297-1-git-send-email-alexander.deucher@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher , dri-devel@lists.freedesktop.org Cc: Alex Deucher List-Id: dri-devel@lists.freedesktop.org Am 16.07.2014 19:26, schrieb Alex Deucher: > Now that fallback to gtt is fixed for cpu access, we can > remove this limit. > > Signed-off-by: Alex Deucher Reviewed-by: Christian K=F6nig > --- > drivers/gpu/drm/radeon/radeon_gem.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon= /radeon_gem.c > index fdd189b..07a13c9 100644 > --- a/drivers/gpu/drm/radeon/radeon_gem.c > +++ b/drivers/gpu/drm/radeon/radeon_gem.c > @@ -55,8 +55,11 @@ int radeon_gem_object_create(struct radeon_device *rde= v, int size, > alignment =3D PAGE_SIZE; > } > = > - /* maximun bo size is the minimun btw visible vram and gtt size */ > - max_size =3D min(rdev->mc.visible_vram_size, rdev->mc.gtt_size); > + /* Maximum bo size is the gtt size since we use the gtt to handle > + * vram to system pool migrations. We could probably remove this > + * check altogether with a little additional work. > + */ > + max_size =3D rdev->mc.gtt_size; > if (size > max_size) { > DRM_DEBUG("Allocation size %dMb bigger than %ldMb limit\n", > size >> 20, max_size >> 20);