From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] raw-posix: Fail gracefully if no working alignment is found
Date: Wed, 16 Jul 2014 12:08:55 -0600 [thread overview]
Message-ID: <53C6BFB7.70804@redhat.com> (raw)
In-Reply-To: <1405525697-9378-3-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
On 07/16/2014 09:48 AM, Kevin Wolf wrote:
> If qemu couldn't find out what O_DIRECT alignment to use with a given
> file, it would run into assert(bdrv_opt_mem_align(bs) != 0); in block.c
> and confuse users. This adds a more descriptive error message for such
> cases.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/raw-posix.c | 35 +++++++++++++++++++++++++++--------
> 1 file changed, 27 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-07-16 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 15:48 [Qemu-devel] [PATCH for-2.1 0/2] raw-posix: Fail gracefully if no working alignment is found Kevin Wolf
2014-07-16 15:48 ` [Qemu-devel] [PATCH 1/2] block: Add Error argument to bdrv_refresh_limits() Kevin Wolf
2014-07-16 18:07 ` Eric Blake
2014-07-16 19:08 ` Kevin Wolf
2014-07-16 15:48 ` [Qemu-devel] [PATCH 2/2] raw-posix: Fail gracefully if no working alignment is found Kevin Wolf
2014-07-16 18:08 ` Eric Blake [this message]
2014-07-18 12:22 ` [Qemu-devel] [PATCH for-2.1 0/2] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C6BFB7.70804@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.