Re: [PATCH 1/1] perf: split package

From: Chong Lu <Chong.Lu@windriver.com>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] perf: split package
Date: Thu, 17 Jul 2014 09:43:22 +0800	[thread overview]
Message-ID: <53C72A3A.50101@windriver.com> (raw)
In-Reply-To: <CADkTA4MMphKfFSKw5ViEBgYn+fFJbABeO1hZg+cs4j0eqr__Jw@mail.gmail.com>

On 07/16/2014 09:04 PM, Bruce Ashfield wrote:
> On Wed, Jul 16, 2014 at 4:00 AM, Chong Lu <Chong.Lu@windriver.com> wrote:
>> Fix incorrect paths to split perf package.
> Can you elaborate here ? This commit message doesn't really tell us much.
> Why is the current split incorrect ? What is the symptom and result of the
> incorrect split ? Are the package contents the same after this change ?
>
> Bruce
Hi Bruce,

Currently, perf can't split to perf-archive, perf-tests, perf-python and 
perf-perl.
All files are included in perf package. For example, like perf-tests 
package:
It generates files in '${exec_prefix}/libexec/perf-core/tests', not in 
'${libdir}/perf/perf-core/tests'.
So I change the files paths to make split successfully.

I will improve commit message and resend a V2.

Best Regards
Chong
>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>> ---
>>   meta/recipes-kernel/perf/perf.bb | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
>> index 20968f9..781a738 100644
>> --- a/meta/recipes-kernel/perf/perf.bb
>> +++ b/meta/recipes-kernel/perf/perf.bb
>> @@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}"
>>
>>   FILES_${PN} += "${libexecdir}/perf-core ${exec_prefix}/libexec/perf-core ${libdir}/traceevent"
>>   FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug"
>> -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive"
>> -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests"
>> -FILES_${PN}-python = "${libdir}/python*/site-packages ${libdir}/perf/perf-core/scripts/python"
>> -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl"
>> +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive"
>> +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests"
>> +FILES_${PN}-python = "${libdir}/python*/site-packages ${exec_prefix}/libexec/perf-core/scripts/python"
>> +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl"
>>
>>
>>   INHIBIT_PACKAGE_DEBUG_SPLIT="1"
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>