From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Date: Thu, 17 Jul 2014 07:37:02 +0000 Subject: Re: [PATCH 1/6] adv7180: Remove duplicate unregister call Message-Id: <53C77D1E.3000901@xs4all.nl> List-Id: References: <1404599185-12353-1-git-send-email-ben.dooks@codethink.co.uk> <1404599185-12353-2-git-send-email-ben.dooks@codethink.co.uk> In-Reply-To: <1404599185-12353-2-git-send-email-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ben Dooks , linux-media@vger.kernel.org, linux-sh@vger.kernel.org Cc: magnus.damm@opensource.se, horms@verge.net.au, g.liakhovetski@gmx.de, linux-kernel@lists.codethink.co.uk, Ian Molton On 07/06/2014 12:26 AM, Ben Dooks wrote: > From: Ian Molton > > This driver moved over to v4l2_async_unregister_subdev() > but still retained a call to v4l2_unregister_subdev(). Remove. > > Signed-off-by: Ian Molton > Signed-off-by: Ben Dooks Acked-by: Hans Verkuil Thanks, Hans > --- > drivers/media/i2c/adv7180.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c > index ac1cdbe..821178d 100644 > --- a/drivers/media/i2c/adv7180.c > +++ b/drivers/media/i2c/adv7180.c > @@ -663,7 +663,6 @@ static int adv7180_remove(struct i2c_client *client) > if (state->irq > 0) > free_irq(client->irq, state); > > - v4l2_device_unregister_subdev(sd); > adv7180_exit_controls(state); > mutex_destroy(&state->mutex); > return 0; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-vbr8.xs4all.nl ([194.109.24.28]:2668 "EHLO smtp-vbr8.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753279AbaGQHh2 (ORCPT ); Thu, 17 Jul 2014 03:37:28 -0400 Message-ID: <53C77D1E.3000901@xs4all.nl> Date: Thu, 17 Jul 2014 09:37:02 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Ben Dooks , linux-media@vger.kernel.org, linux-sh@vger.kernel.org CC: magnus.damm@opensource.se, horms@verge.net.au, g.liakhovetski@gmx.de, linux-kernel@lists.codethink.co.uk, Ian Molton Subject: Re: [PATCH 1/6] adv7180: Remove duplicate unregister call References: <1404599185-12353-1-git-send-email-ben.dooks@codethink.co.uk> <1404599185-12353-2-git-send-email-ben.dooks@codethink.co.uk> In-Reply-To: <1404599185-12353-2-git-send-email-ben.dooks@codethink.co.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 07/06/2014 12:26 AM, Ben Dooks wrote: > From: Ian Molton > > This driver moved over to v4l2_async_unregister_subdev() > but still retained a call to v4l2_unregister_subdev(). Remove. > > Signed-off-by: Ian Molton > Signed-off-by: Ben Dooks Acked-by: Hans Verkuil Thanks, Hans > --- > drivers/media/i2c/adv7180.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c > index ac1cdbe..821178d 100644 > --- a/drivers/media/i2c/adv7180.c > +++ b/drivers/media/i2c/adv7180.c > @@ -663,7 +663,6 @@ static int adv7180_remove(struct i2c_client *client) > if (state->irq > 0) > free_irq(client->irq, state); > > - v4l2_device_unregister_subdev(sd); > adv7180_exit_controls(state); > mutex_destroy(&state->mutex); > return 0; >