From: Daniel Mack <daniel@zonque.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, broonie@kernel.org,
dh.herrmann@gmail.com, devicetree@vger.kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCH v4] Input: Add driver for Microchip's CAP1106
Date: Thu, 17 Jul 2014 09:55:54 +0200 [thread overview]
Message-ID: <53C7818A.30703@zonque.org> (raw)
In-Reply-To: <20140714184642.GA38980@core.coreip.homeip.net>
On 07/14/2014 08:46 PM, Dmitry Torokhov wrote:
> On Mon, Jul 14, 2014 at 04:28:02PM +0200, Daniel Mack wrote:
>> +
>> +static int cap1106_i2c_remove(struct i2c_client *i2c_client)
>> +{
>> + struct cap1106_priv *priv = i2c_get_clientdata(i2c_client);
>> +
>> + input_unregister_device(priv->idev);
>> +
>
> No need to call unregister on managed input devices.
Addressed in v5, which I posted already.
> Otherwise if DT guys are happy with bindings I am happy with the patch.
That seems to be the case. I guess we're done then :)
Thanks again for the reviews, everyone.
Daniel
prev parent reply other threads:[~2014-07-17 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 14:28 [PATCH v4] Input: Add driver for Microchip's CAP1106 Daniel Mack
2014-07-14 18:46 ` Dmitry Torokhov
2014-07-15 8:53 ` Mark Rutland
2014-07-17 7:55 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C7818A.30703@zonque.org \
--to=daniel@zonque.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dh.herrmann@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.