From: Bo Shen <voice.shen@atmel.com>
To: Raphael Poggi <poggi.raph@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: atmel_nand: enable PMECC for 8k page nand
Date: Thu, 17 Jul 2014 18:05:17 +0800 [thread overview]
Message-ID: <53C79FDD.1070901@atmel.com> (raw)
In-Reply-To: <1405587095-23308-3-git-send-email-poggi.raph@gmail.com>
Hi Raphael,
On 07/17/2014 04:51 PM, Raphael Poggi wrote:
> Enable the PMECC to support 8k page.
>
> Signed-off-by: Raphaël Poggi <poggi.raph@gmail.com>
Acked-by: Bo Shen <voice.shen@atmel.com>
> ---
> drivers/mtd/nand/atmel_nand.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index fa596ed..36a60d1 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -796,7 +796,9 @@ static int __init atmel_pmecc_nand_init_params(struct device_d *dev,
> switch (mtd->writesize) {
> case 2048:
> case 4096:
> - host->pmecc_degree = PMECC_GF_DIMENSION_13;
> + case 8192:
> + host->pmecc_degree = (sector_size == 512) ?
> + PMECC_GF_DIMENSION_13 : PMECC_GF_DIMENSION_14;
Actually, this is a fix + 8K page support.
If some commit message or split into two patches will be better.
> host->pmecc_cw_len = (1 << host->pmecc_degree) - 1;
> host->pmecc_sector_number = mtd->writesize / sector_size;
> host->pmecc_bytes_per_sector = pmecc_get_ecc_bytes(
>
Best Regards,
Bo Shen
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-07-17 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 8:51 [PATCH 0/2] mtd: atmel_nand: add support for 8k page nand Raphael Poggi
2014-07-17 8:51 ` [PATCH 1/2] mtd: atmel_nand: increase chip_delay Raphael Poggi
2014-07-17 10:02 ` Bo Shen
2014-07-17 8:51 ` [PATCH 2/2] mtd: atmel_nand: enable PMECC for 8k page nand Raphael Poggi
2014-07-17 10:05 ` Bo Shen [this message]
2014-07-17 11:45 ` Raphaël Poggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C79FDD.1070901@atmel.com \
--to=voice.shen@atmel.com \
--cc=barebox@lists.infradead.org \
--cc=poggi.raph@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.