From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <wanpeng.li@linux.intel.com>,
"Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@kernel.org>, Bandan Das <bsd@redhat.com>,
"Hu, Robert" <robert.hu@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] KVM: nVMX: Fix fail to get nested ack intr's vector during nested vmexit
Date: Thu, 17 Jul 2014 12:43:17 +0200 [thread overview]
Message-ID: <53C7A8C5.2090002@redhat.com> (raw)
In-Reply-To: <20140717100130.GA9118@kernel>
Il 17/07/2014 12:01, Wanpeng Li ha scritto:
> That is my original proposal solution of this bug. However, what I concern
> after more think is since kvm_lapic_find_highest_irr will not clear
> irr, if the intr will be injected by kvm_86_ops->hwapic_irr_update(vcpu,
> kvm_lapic_find_highest_irr(vcpu)) which called by vcpu_enter_guest() again?
>
> Any idea, Paolo?
The processor should do that when it does the virtual interrupt
delivery. It will do (29.2.2):
Vector := RVI;
VISR[Vector] := 1;
SVI := Vector;
VIRR[Vector] := 0;
If VIRR not empty
then RVI := highest index of bit set in VIRR
else RVI := 0
Fi;
deliver interrupt with Vector through IDT;
Please post a patch, so we can reason on it better.
Paolo
next prev parent reply other threads:[~2014-07-17 10:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 4:56 [PATCH 1/3] KVM: nVMX: Fix virtual interrupt delivery injection Wanpeng Li
2014-07-17 4:56 ` [PATCH 2/3] KVM: nVMX: Fix fail to get nested ack intr's vector during nested vmexit Wanpeng Li
2014-07-17 5:15 ` Zhang, Yang Z
2014-07-17 8:49 ` Paolo Bonzini
2014-07-17 9:13 ` Zhang, Yang Z
2014-07-17 10:01 ` Wanpeng Li
2014-07-17 10:43 ` Paolo Bonzini [this message]
2014-07-17 10:03 ` Wanpeng Li
2014-07-17 4:56 ` [PATCH 3/3] KVM: nVMX: Fix vmptrld fail and vmwrite error when L1 goes down Wanpeng Li
2014-07-17 8:56 ` Paolo Bonzini
2014-07-17 9:04 ` Paolo Bonzini
2014-07-17 8:55 ` [PATCH 1/3] KVM: nVMX: Fix virtual interrupt delivery injection Paolo Bonzini
2014-07-17 9:03 ` Zhang, Yang Z
2014-07-17 9:11 ` Wanpeng Li
2014-07-17 10:43 ` Paolo Bonzini
2014-07-17 11:08 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C7A8C5.2090002@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=robert.hu@intel.com \
--cc=wanpeng.li@linux.intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.