From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [PATCH 04/83] drm/radeon: Add radeon <--> kfd interface Date: Thu, 17 Jul 2014 14:55:33 +0300 Message-ID: <53C7B9B5.6070208@amd.com> References: <1405029027-6085-1-git-send-email-oded.gabbay@amd.com> <1405029027-6085-3-git-send-email-oded.gabbay@amd.com> <1405031913.2796.7.camel@joe-AO725> <20140711162424.GE1870@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20140711162424.GE1870@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Jerome Glisse , Joe Perches Cc: David Airlie , Alex Deucher , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, John Bridgman , Andrew Lewycky , Joerg Roedel , =?ISO-8859-1?Q?Christian_K=F6nig?= List-Id: dri-devel@lists.freedesktop.org On 11/07/14 19:24, Jerome Glisse wrote: > On Thu, Jul 10, 2014 at 03:38:33PM -0700, Joe Perches wrote: >> On Fri, 2014-07-11 at 00:50 +0300, Oded Gabbay wrote: >>> This patch adds the interface between the radeon driver and the kfd >>> driver. The interface implementation is contained in >>> radeon_kfd.c and radeon_kfd.h. >> [] >>> include/linux/radeon_kfd.h | 67 ++++++++++++++++++++++++= ++ >> >> Is there a good reason to put this file in include/linux? >> > > Agrees, we do not want to clutter include/linux/ with specific driver > include, i think its one of the rules even thought there is some hw h= eader > already in there. > > I would rather see either a new dir include/hsa or inside include/drm= =2E > > Cheers, > J=E9r=F4me > Moved to drm/radeon in v2 of the patchset Oded