From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7nvj-0007LP-5C for qemu-devel@nongnu.org; Thu, 17 Jul 2014 11:49:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7nva-0005SO-OZ for qemu-devel@nongnu.org; Thu, 17 Jul 2014 11:49:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39021 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7nva-0005S4-Ho for qemu-devel@nongnu.org; Thu, 17 Jul 2014 11:49:02 -0400 Message-ID: <53C7F06B.4080103@suse.de> Date: Thu, 17 Jul 2014 17:48:59 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1404032955-2591-1-git-send-email-marcel.a@redhat.com> <20140629113701.GA26161@redhat.com> <1405606506.2696.60.camel@localhost.localdomain> <53C7DB9F.1060305@redhat.com> In-Reply-To: <53C7DB9F.1060305@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Marcel Apfelbaum , Peter Maydell Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, aliguori@amazon.com, mdroth@linux.vnet.ibm.com Am 17.07.2014 16:20, schrieb Paolo Bonzini: > Il 17/07/2014 16:15, Marcel Apfelbaum ha scritto: >> On Sun, 2014-06-29 at 14:37 +0300, Michael S. Tsirkin wrote: >>> On Sun, Jun 29, 2014 at 12:09:15PM +0300, Marcel Apfelbaum wrote: >>>> Replaced '_' with '-' to comply with QOM guidelines. >>>> Made the conversion from HMP to QMP in vl.c >>>> >>>> Signed-off-by: Marcel Apfelbaum >>> >>> Nothing to do with me, pls merge through Andrea's or Paolo's tree. >>> FWIW >> Ping. >> I thought we want this in 2.1 >=20 > Renaming properties is fine according to the QOM guidelines, so I think > it can be left for 2.2. >=20 > Sorry for the delay, this patch escaped me completely. Sorry, just seeing this patch now, too. My argument for getting this into 2.1 had been to avoid tools picking up these to-be-renamed property names from the start. At this point, I'm not so sure whether it's worse to break management tools or potentially some rarely used/tested option - if we decide for 2.2, is backporting to 2.1.1 an option if we document it in the release notes? Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg