From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48687)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1X7q5f-00007b-HY
	for qemu-devel@nongnu.org; Thu, 17 Jul 2014 14:07:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1X7q5Y-0007KA-QP
	for qemu-devel@nongnu.org; Thu, 17 Jul 2014 14:07:35 -0400
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:50534)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1X7q5Y-0007Jx-Jo
	for qemu-devel@nongnu.org; Thu, 17 Jul 2014 14:07:28 -0400
Message-ID: <53C810CF.2060108@weilnetz.de>
Date: Thu, 17 Jul 2014 20:07:11 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1405619812-8422-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1405619812-8422-1-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.1] po: Fix Makefile rules
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

Am 17.07.2014 19:56, schrieb Stefan Weil:
> Adding 'update' to the phony targets fixes this error:
> 
> $ LANG=C make -C po update
> make: Entering directory `/qemu/po'
>   LINK  update
> /qemu/po/de_DE.po: file not recognized: File format not recognized
> collect2: error: ld returned 1 exit status
> make: *** [update] Error 1
> make: Leaving directory `/qemu/po'
> 
> Some other phony targets (build, install) were also added, and the
> existing .PHONY statement was moved to a more prominent position at
> the beginning of the Makefile.
> 
> The patch also fixes a 2nd bug. The default target should be 'all',
> but instead 'modules' (from rules.mak) was the default. Fix this by
> adding 'all' as a target before any include statement.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 

I just noticed that both errors which I mentioned in the commit message
only occur when there was no "make configure" run in the source tree.

My normal builds are always out-of-tree, but for po updates, running
"make -C po update" is the fastest solution, and it should work without
a prior configuration step because that is not needed for the resulting
.po files.

Stefan