Re: [PATCH] backports: include gpio consumer.h

[Hauke Mehrtens <hauke@hauke-m.de>]

On 07/10/2014 03:31 PM, Stefan Assmann wrote:
> While doing a make allmodconfig I noticed the following:
>   CC [M]  /dev/shm/backports-next/drivers/media/i2c/adv7604.o
> /dev/shm/backports-next/drivers/media/i2c/adv7604.c:31:33: fatal error: linux/gpio/consumer.h: No such file or directory
> 
> Including the header fixes the error.
> 
> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
> ---
>  copy-list | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/copy-list b/copy-list
> index 7ad8972..b52e9f2 100644
> --- a/copy-list
> +++ b/copy-list
> @@ -107,6 +107,10 @@ drivers/net/ethernet/intel/Kconfig
>  drivers/net/ethernet/intel/Makefile
>  drivers/net/ethernet/intel/igb/
>  
> +# gpio
> +include/linux/gpio/
> +include/linux/gpio/consumer.h
> +
>  # wwan drivers
>  include/uapi/linux/usb/cdc.h
>  include/uapi/linux/usb/cdc-wdm.h
> 
Is this correct? backports does not provide the implementation of the
functions in include/linux/gpio/consumer.h and it will result in hard to
debug problems with some function signature is different in our version
of consumer.h and the version in the kernel.

I am against backporting this and would add an empty version of this header.

Hauke