From: Antti Palosaari <crope@iki.fi>
To: Luis Alves <ljalvs@gmail.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1 v2] si2168: Support Si2168-A20 firmware downloading.
Date: Fri, 18 Jul 2014 01:56:22 +0300 [thread overview]
Message-ID: <53C85496.8060306@iki.fi> (raw)
In-Reply-To: <1405637017-24036-1-git-send-email-ljalvs@gmail.com>
Thank for the patch! I will apply that sure too.
Driver supports now all Si2168 versions?
regards
Antti
On 07/18/2014 01:43 AM, Luis Alves wrote:
> (ignore the previous one, it was incomplete)
>
> This adds support for the Si2168-A20 firmware download.
> Extracting the firmware:
>
> wget http://www.tbsdtv.com/download/document/tbs6281/tbs6281-t2-t-driver_v1.0.0.6.zip
> unzip tbs6281-t2-t-driver_v1.0.0.6.zip
> dd if=tbs-6281_x64/tbs6281_64.sys of=dvb-demod-si2168-a20-01.fw count=28656 bs=1 skip=1625088
>
> md5sum:
> 32e06713b33915f674bfb2c209beaea5 /lib/firmware/dvb-demod-si2168-a20-01.fw
>
> Regards,
> Luis
>
>
> Signed-off-by: Luis Alves <ljalvs@gmail.com>
> ---
> drivers/media/dvb-frontends/si2168.c | 5 +++++
> drivers/media/dvb-frontends/si2168_priv.h | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
> index 7e45eeab..50c4a91 100644
> --- a/drivers/media/dvb-frontends/si2168.c
> +++ b/drivers/media/dvb-frontends/si2168.c
> @@ -377,10 +377,14 @@ static int si2168_init(struct dvb_frontend *fe)
> chip_id = cmd.args[1] << 24 | cmd.args[2] << 16 | cmd.args[3] << 8 |
> cmd.args[4] << 0;
>
> + #define SI2168_A20 ('A' << 24 | 68 << 16 | '2' << 8 | '0' << 0)
> #define SI2168_A30 ('A' << 24 | 68 << 16 | '3' << 8 | '0' << 0)
> #define SI2168_B40 ('B' << 24 | 68 << 16 | '4' << 8 | '0' << 0)
>
> switch (chip_id) {
> + case SI2168_A20:
> + fw_file = SI2168_A20_FIRMWARE;
> + break;
> case SI2168_A30:
> fw_file = SI2168_A30_FIRMWARE;
> break;
> @@ -672,5 +676,6 @@ module_i2c_driver(si2168_driver);
> MODULE_AUTHOR("Antti Palosaari <crope@iki.fi>");
> MODULE_DESCRIPTION("Silicon Labs Si2168 DVB-T/T2/C demodulator driver");
> MODULE_LICENSE("GPL");
> +MODULE_FIRMWARE(SI2168_A20_FIRMWARE);
> MODULE_FIRMWARE(SI2168_A30_FIRMWARE);
> MODULE_FIRMWARE(SI2168_B40_FIRMWARE);
> diff --git a/drivers/media/dvb-frontends/si2168_priv.h b/drivers/media/dvb-frontends/si2168_priv.h
> index bebb68a..ebbf502 100644
> --- a/drivers/media/dvb-frontends/si2168_priv.h
> +++ b/drivers/media/dvb-frontends/si2168_priv.h
> @@ -22,6 +22,7 @@
> #include <linux/firmware.h>
> #include <linux/i2c-mux.h>
>
> +#define SI2168_A20_FIRMWARE "dvb-demod-si2168-a20-01.fw"
> #define SI2168_A30_FIRMWARE "dvb-demod-si2168-a30-01.fw"
> #define SI2168_B40_FIRMWARE "dvb-demod-si2168-b40-01.fw"
> #define SI2168_B40_FIRMWARE_FALLBACK "dvb-demod-si2168-02.fw"
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-07-17 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 22:43 [PATCH 1/1 v2] si2168: Support Si2168-A20 firmware downloading Luis Alves
2014-07-17 22:56 ` Antti Palosaari [this message]
2014-07-17 23:04 ` Luis Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C85496.8060306@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=ljalvs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.