From: Guenter Roeck <linux@roeck-us.net>
To: Richard Weinberger <richard@nod.at>, akpm@linux-foundation.org
Cc: apw@canonical.com, joe@perches.com, tytso@mit.edu,
dwalter@google.com, bp@suse.de, neilb@suse.de, hch@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Remove --file option
Date: Fri, 18 Jul 2014 00:29:37 -0700 [thread overview]
Message-ID: <53C8CCE1.4000105@roeck-us.net> (raw)
In-Reply-To: <1405611268-12463-1-git-send-email-richard@nod.at>
On 07/17/2014 08:34 AM, Richard Weinberger wrote:
> checkpatch.pl is a nice tool to find issues in patches.
> Sadly this tool gets more and more abused by various people to create
> style cleanups for source files within the kernel.
> In order to deal with that bad habit let's remove the --file option
> and bring checkpatch.pl back to its original purpose.
>
I have a number of problems with this patch.
First, 'abuse' is a relative term. It describes a use you
(and possibly many others) may find objectionable, but that
does not mean all uses are objectionable.
Second, just because something is abused doesn't mean it would be
a good idea to take it away. Many of the amendmends to the US
Constitution can be abused. Should freedom of speech be taken away
because it can be abused ? I hope not. Many drugs can be abused.
Should they be taken away ? I hope not. And so on.
Using your argument, you can take away anything that can be abused,
which is pretty much everything. Not a good idea.
Guenter
next prev parent reply other threads:[~2014-07-18 8:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 15:34 [PATCH] checkpatch.pl: Remove --file option Richard Weinberger
2014-07-17 15:38 ` Borislav Petkov
2014-07-17 15:51 ` Joe Perches
2014-07-17 16:02 ` Borislav Petkov
2014-07-17 16:24 ` Joe Perches
2014-07-22 5:27 ` Kalle Valo
2014-08-04 14:30 ` Pavel Machek
2014-07-17 22:43 ` Thomas Gleixner
2014-07-18 7:29 ` Guenter Roeck [this message]
2014-07-18 8:23 ` Borislav Petkov
2014-07-18 13:37 ` Guenter Roeck
2014-07-18 13:46 ` Richard Weinberger
2014-07-18 13:56 ` Guenter Roeck
2014-07-18 14:22 ` Borislav Petkov
2014-07-18 14:21 ` Christoph Hellwig
2014-07-18 14:27 ` Borislav Petkov
2014-07-18 14:43 ` Guenter Roeck
2014-07-18 14:56 ` Borislav Petkov
2014-07-18 14:17 ` Lars-Peter Clausen
2014-07-18 14:24 ` Borislav Petkov
2014-07-18 14:35 ` Joe Perches
2014-07-18 14:49 ` Borislav Petkov
2014-07-18 14:57 ` Joe Perches
2014-07-18 15:06 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C8CCE1.4000105@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bp@suse.de \
--cc=dwalter@google.com \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.