* [PATCH] backports: include gpio consumer.h
@ 2014-07-10 13:31 Stefan Assmann
2014-07-17 20:23 ` Luis R. Rodriguez
2014-07-17 20:42 ` Hauke Mehrtens
0 siblings, 2 replies; 6+ messages in thread
From: Stefan Assmann @ 2014-07-10 13:31 UTC (permalink / raw)
To: mcgrof; +Cc: backports, sassmann
While doing a make allmodconfig I noticed the following:
CC [M] /dev/shm/backports-next/drivers/media/i2c/adv7604.o
/dev/shm/backports-next/drivers/media/i2c/adv7604.c:31:33: fatal error: linux/gpio/consumer.h: No such file or directory
Including the header fixes the error.
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
---
copy-list | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/copy-list b/copy-list
index 7ad8972..b52e9f2 100644
--- a/copy-list
+++ b/copy-list
@@ -107,6 +107,10 @@ drivers/net/ethernet/intel/Kconfig
drivers/net/ethernet/intel/Makefile
drivers/net/ethernet/intel/igb/
+# gpio
+include/linux/gpio/
+include/linux/gpio/consumer.h
+
# wwan drivers
include/uapi/linux/usb/cdc.h
include/uapi/linux/usb/cdc-wdm.h
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] backports: include gpio consumer.h
2014-07-10 13:31 [PATCH] backports: include gpio consumer.h Stefan Assmann
@ 2014-07-17 20:23 ` Luis R. Rodriguez
2014-07-17 20:42 ` Hauke Mehrtens
1 sibling, 0 replies; 6+ messages in thread
From: Luis R. Rodriguez @ 2014-07-17 20:23 UTC (permalink / raw)
To: Stefan Assmann; +Cc: backports
[-- Attachment #1: Type: text/plain, Size: 458 bytes --]
On Thu, Jul 10, 2014 at 03:31:50PM +0200, Stefan Assmann wrote:
> While doing a make allmodconfig I noticed the following:
> CC [M] /dev/shm/backports-next/drivers/media/i2c/adv7604.o
> /dev/shm/backports-next/drivers/media/i2c/adv7604.c:31:33: fatal error: linux/gpio/consumer.h: No such file or directory
>
> Including the header fixes the error.
>
> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Applied and pushed, thanks!
Luis
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] backports: include gpio consumer.h
2014-07-10 13:31 [PATCH] backports: include gpio consumer.h Stefan Assmann
2014-07-17 20:23 ` Luis R. Rodriguez
@ 2014-07-17 20:42 ` Hauke Mehrtens
2014-07-17 21:27 ` Luis R. Rodriguez
1 sibling, 1 reply; 6+ messages in thread
From: Hauke Mehrtens @ 2014-07-17 20:42 UTC (permalink / raw)
To: Stefan Assmann, mcgrof; +Cc: backports
On 07/10/2014 03:31 PM, Stefan Assmann wrote:
> While doing a make allmodconfig I noticed the following:
> CC [M] /dev/shm/backports-next/drivers/media/i2c/adv7604.o
> /dev/shm/backports-next/drivers/media/i2c/adv7604.c:31:33: fatal error: linux/gpio/consumer.h: No such file or directory
>
> Including the header fixes the error.
>
> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
> ---
> copy-list | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/copy-list b/copy-list
> index 7ad8972..b52e9f2 100644
> --- a/copy-list
> +++ b/copy-list
> @@ -107,6 +107,10 @@ drivers/net/ethernet/intel/Kconfig
> drivers/net/ethernet/intel/Makefile
> drivers/net/ethernet/intel/igb/
>
> +# gpio
> +include/linux/gpio/
> +include/linux/gpio/consumer.h
> +
> # wwan drivers
> include/uapi/linux/usb/cdc.h
> include/uapi/linux/usb/cdc-wdm.h
>
Is this correct? backports does not provide the implementation of the
functions in include/linux/gpio/consumer.h and it will result in hard to
debug problems with some function signature is different in our version
of consumer.h and the version in the kernel.
I am against backporting this and would add an empty version of this header.
Hauke
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] backports: include gpio consumer.h
2014-07-17 20:42 ` Hauke Mehrtens
@ 2014-07-17 21:27 ` Luis R. Rodriguez
2014-07-18 7:41 ` Stefan Assmann
0 siblings, 1 reply; 6+ messages in thread
From: Luis R. Rodriguez @ 2014-07-17 21:27 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: Stefan Assmann, backports@vger.kernel.org
On Thu, Jul 17, 2014 at 1:42 PM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> On 07/10/2014 03:31 PM, Stefan Assmann wrote:
>> While doing a make allmodconfig I noticed the following:
>> CC [M] /dev/shm/backports-next/drivers/media/i2c/adv7604.o
>> /dev/shm/backports-next/drivers/media/i2c/adv7604.c:31:33: fatal error: linux/gpio/consumer.h: No such file or directory
>>
>> Including the header fixes the error.
>>
>> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
>> ---
>> copy-list | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/copy-list b/copy-list
>> index 7ad8972..b52e9f2 100644
>> --- a/copy-list
>> +++ b/copy-list
>> @@ -107,6 +107,10 @@ drivers/net/ethernet/intel/Kconfig
>> drivers/net/ethernet/intel/Makefile
>> drivers/net/ethernet/intel/igb/
>>
>> +# gpio
>> +include/linux/gpio/
>> +include/linux/gpio/consumer.h
>> +
>> # wwan drivers
>> include/uapi/linux/usb/cdc.h
>> include/uapi/linux/usb/cdc-wdm.h
>>
> Is this correct? backports does not provide the implementation of the
> functions in include/linux/gpio/consumer.h and it will result in hard to
> debug problems with some function signature is different in our version
> of consumer.h and the version in the kernel.
>
> I am against backporting this and would add an empty version of this header.
config GPIO_DEVRES
def_bool y
depends on HAS_IOMEM
Indeed, we can't backport this yet as we have no support for in-kernel
functionality to be backported yet.
Reverted.
Luis
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] backports: include gpio consumer.h
2014-07-17 21:27 ` Luis R. Rodriguez
@ 2014-07-18 7:41 ` Stefan Assmann
2014-07-19 16:17 ` Hauke Mehrtens
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Assmann @ 2014-07-18 7:41 UTC (permalink / raw)
To: Luis R. Rodriguez, Hauke Mehrtens; +Cc: backports@vger.kernel.org
On 17.07.2014 23:27, Luis R. Rodriguez wrote:
> On Thu, Jul 17, 2014 at 1:42 PM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
>> On 07/10/2014 03:31 PM, Stefan Assmann wrote:
>>> While doing a make allmodconfig I noticed the following:
>>> CC [M] /dev/shm/backports-next/drivers/media/i2c/adv7604.o
>>> /dev/shm/backports-next/drivers/media/i2c/adv7604.c:31:33: fatal error: linux/gpio/consumer.h: No such file or directory
>>>
>>> Including the header fixes the error.
>>>
>>> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
>>> ---
>>> copy-list | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/copy-list b/copy-list
>>> index 7ad8972..b52e9f2 100644
>>> --- a/copy-list
>>> +++ b/copy-list
>>> @@ -107,6 +107,10 @@ drivers/net/ethernet/intel/Kconfig
>>> drivers/net/ethernet/intel/Makefile
>>> drivers/net/ethernet/intel/igb/
>>>
>>> +# gpio
>>> +include/linux/gpio/
>>> +include/linux/gpio/consumer.h
>>> +
>>> # wwan drivers
>>> include/uapi/linux/usb/cdc.h
>>> include/uapi/linux/usb/cdc-wdm.h
>>>
>> Is this correct? backports does not provide the implementation of the
>> functions in include/linux/gpio/consumer.h and it will result in hard to
>> debug problems with some function signature is different in our version
>> of consumer.h and the version in the kernel.
>>
>> I am against backporting this and would add an empty version of this header.
>
> config GPIO_DEVRES
> def_bool y
> depends on HAS_IOMEM
>
> Indeed, we can't backport this yet as we have no support for in-kernel
> functionality to be backported yet.
>
> Reverted.
So, with just an empty header we get:
CC [M] /dev/shm/backports-next/drivers/media/i2c/adv7604.o
/dev/shm/backports-next/drivers/media/i2c/adv7604.c: In function ‘adv7604_set_hpd’:
/dev/shm/backports-next/drivers/media/i2c/adv7604.c:613:3: error: implicit declaration of function ‘gpiod_set_value_cansleep’ [-Werror=implicit-function-declaration]
gpiod_set_value_cansleep(state->hpd_gpio[i], hpd & BIT(i));
^
/dev/shm/backports-next/drivers/media/i2c/adv7604.c: In function ‘adv7604_probe’:
/dev/shm/backports-next/drivers/media/i2c/adv7604.c:2797:4: error: implicit declaration of function ‘devm_gpiod_get_index’ [-Werror=implicit-function-declaration]
devm_gpiod_get_index(&client->dev, "hpd", i);
^
/dev/shm/backports-next/drivers/media/i2c/adv7604.c:2796:22: warning: assignment makes pointer from integer without a cast [enabled by default]
state->hpd_gpio[i] =
^
/dev/shm/backports-next/drivers/media/i2c/adv7604.c:2801:3: error: implicit declaration of function ‘gpiod_direction_output’ [-Werror=implicit-function-declaration]
gpiod_direction_output(state->hpd_gpio[i], 0);
If we can't backport these, what do we do? Disable the module for now?
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] backports: include gpio consumer.h
2014-07-18 7:41 ` Stefan Assmann
@ 2014-07-19 16:17 ` Hauke Mehrtens
0 siblings, 0 replies; 6+ messages in thread
From: Hauke Mehrtens @ 2014-07-19 16:17 UTC (permalink / raw)
To: Stefan Assmann, Luis R. Rodriguez; +Cc: backports@vger.kernel.org
On 07/18/2014 09:41 AM, Stefan Assmann wrote:
> On 17.07.2014 23:27, Luis R. Rodriguez wrote:
>> On Thu, Jul 17, 2014 at 1:42 PM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
>>> On 07/10/2014 03:31 PM, Stefan Assmann wrote:
>>>> While doing a make allmodconfig I noticed the following:
>>>> CC [M] /dev/shm/backports-next/drivers/media/i2c/adv7604.o
>>>> /dev/shm/backports-next/drivers/media/i2c/adv7604.c:31:33: fatal
>>>> error: linux/gpio/consumer.h: No such file or directory
>>>>
>>>> Including the header fixes the error.
>>>>
>>>> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
>>>> ---
>>>> copy-list | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/copy-list b/copy-list
>>>> index 7ad8972..b52e9f2 100644
>>>> --- a/copy-list
>>>> +++ b/copy-list
>>>> @@ -107,6 +107,10 @@ drivers/net/ethernet/intel/Kconfig
>>>> drivers/net/ethernet/intel/Makefile
>>>> drivers/net/ethernet/intel/igb/
>>>>
>>>> +# gpio
>>>> +include/linux/gpio/
>>>> +include/linux/gpio/consumer.h
>>>> +
>>>> # wwan drivers
>>>> include/uapi/linux/usb/cdc.h
>>>> include/uapi/linux/usb/cdc-wdm.h
>>>>
>>> Is this correct? backports does not provide the implementation of the
>>> functions in include/linux/gpio/consumer.h and it will result in hard to
>>> debug problems with some function signature is different in our version
>>> of consumer.h and the version in the kernel.
>>>
>>> I am against backporting this and would add an empty version of this
>>> header.
>>
>> config GPIO_DEVRES
>> def_bool y
>> depends on HAS_IOMEM
>>
>> Indeed, we can't backport this yet as we have no support for in-kernel
>> functionality to be backported yet.
>>
>> Reverted.
>
> So, with just an empty header we get:
> CC [M] /dev/shm/backports-next/drivers/media/i2c/adv7604.o
> /dev/shm/backports-next/drivers/media/i2c/adv7604.c: In function
> ‘adv7604_set_hpd’:
> /dev/shm/backports-next/drivers/media/i2c/adv7604.c:613:3: error:
> implicit declaration of function ‘gpiod_set_value_cansleep’
> [-Werror=implicit-function-declaration]
> gpiod_set_value_cansleep(state->hpd_gpio[i], hpd & BIT(i));
> ^
> /dev/shm/backports-next/drivers/media/i2c/adv7604.c: In function
> ‘adv7604_probe’:
> /dev/shm/backports-next/drivers/media/i2c/adv7604.c:2797:4: error:
> implicit declaration of function ‘devm_gpiod_get_index’
> [-Werror=implicit-function-declaration]
> devm_gpiod_get_index(&client->dev, "hpd", i);
> ^
> /dev/shm/backports-next/drivers/media/i2c/adv7604.c:2796:22: warning:
> assignment makes pointer from integer without a cast [enabled by default]
> state->hpd_gpio[i] =
> ^
> /dev/shm/backports-next/drivers/media/i2c/adv7604.c:2801:3: error:
> implicit declaration of function ‘gpiod_direction_output’
> [-Werror=implicit-function-declaration]
> gpiod_direction_output(state->hpd_gpio[i], 0);
>
> If we can't backport these, what do we do? Disable the module for now?
>
> Stefan
Hi,
if you do not need this driver removing it or make it depend on kernel
3.13 in which the header was added should be fine.
Hauke
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-19 16:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-10 13:31 [PATCH] backports: include gpio consumer.h Stefan Assmann
2014-07-17 20:23 ` Luis R. Rodriguez
2014-07-17 20:42 ` Hauke Mehrtens
2014-07-17 21:27 ` Luis R. Rodriguez
2014-07-18 7:41 ` Stefan Assmann
2014-07-19 16:17 ` Hauke Mehrtens
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.