From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from app1b.xlhost.de ([84.200.252.162]:36772 "EHLO app1b.xlhost.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbaGRHuG (ORCPT ); Fri, 18 Jul 2014 03:50:06 -0400 Message-ID: <53C8CFBE.1030208@kpanic.de> (sfid-20140718_095008_999150_BA77BCE6) Date: Fri, 18 Jul 2014 09:41:50 +0200 From: Stefan Assmann MIME-Version: 1.0 To: "Luis R. Rodriguez" , Hauke Mehrtens CC: "backports@vger.kernel.org" Subject: Re: [PATCH] backports: include gpio consumer.h References: <1404999110-13791-1-git-send-email-sassmann@kpanic.de> <53C83544.7030306@hauke-m.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: backports-owner@vger.kernel.org List-ID: On 17.07.2014 23:27, Luis R. Rodriguez wrote: > On Thu, Jul 17, 2014 at 1:42 PM, Hauke Mehrtens wrote: >> On 07/10/2014 03:31 PM, Stefan Assmann wrote: >>> While doing a make allmodconfig I noticed the following: >>> CC [M] /dev/shm/backports-next/drivers/media/i2c/adv7604.o >>> /dev/shm/backports-next/drivers/media/i2c/adv7604.c:31:33: fatal error: linux/gpio/consumer.h: No such file or directory >>> >>> Including the header fixes the error. >>> >>> Signed-off-by: Stefan Assmann >>> --- >>> copy-list | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/copy-list b/copy-list >>> index 7ad8972..b52e9f2 100644 >>> --- a/copy-list >>> +++ b/copy-list >>> @@ -107,6 +107,10 @@ drivers/net/ethernet/intel/Kconfig >>> drivers/net/ethernet/intel/Makefile >>> drivers/net/ethernet/intel/igb/ >>> >>> +# gpio >>> +include/linux/gpio/ >>> +include/linux/gpio/consumer.h >>> + >>> # wwan drivers >>> include/uapi/linux/usb/cdc.h >>> include/uapi/linux/usb/cdc-wdm.h >>> >> Is this correct? backports does not provide the implementation of the >> functions in include/linux/gpio/consumer.h and it will result in hard to >> debug problems with some function signature is different in our version >> of consumer.h and the version in the kernel. >> >> I am against backporting this and would add an empty version of this header. > > config GPIO_DEVRES > def_bool y > depends on HAS_IOMEM > > Indeed, we can't backport this yet as we have no support for in-kernel > functionality to be backported yet. > > Reverted. So, with just an empty header we get: CC [M] /dev/shm/backports-next/drivers/media/i2c/adv7604.o /dev/shm/backports-next/drivers/media/i2c/adv7604.c: In function ‘adv7604_set_hpd’: /dev/shm/backports-next/drivers/media/i2c/adv7604.c:613:3: error: implicit declaration of function ‘gpiod_set_value_cansleep’ [-Werror=implicit-function-declaration] gpiod_set_value_cansleep(state->hpd_gpio[i], hpd & BIT(i)); ^ /dev/shm/backports-next/drivers/media/i2c/adv7604.c: In function ‘adv7604_probe’: /dev/shm/backports-next/drivers/media/i2c/adv7604.c:2797:4: error: implicit declaration of function ‘devm_gpiod_get_index’ [-Werror=implicit-function-declaration] devm_gpiod_get_index(&client->dev, "hpd", i); ^ /dev/shm/backports-next/drivers/media/i2c/adv7604.c:2796:22: warning: assignment makes pointer from integer without a cast [enabled by default] state->hpd_gpio[i] = ^ /dev/shm/backports-next/drivers/media/i2c/adv7604.c:2801:3: error: implicit declaration of function ‘gpiod_direction_output’ [-Werror=implicit-function-declaration] gpiod_direction_output(state->hpd_gpio[i], 0); If we can't backport these, what do we do? Disable the module for now? Stefan