From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38324)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <m.gibula@beyond.pl>) id 1X84XK-0004Gf-On
	for qemu-devel@nongnu.org; Fri, 18 Jul 2014 05:33:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <m.gibula@beyond.pl>) id 1X84XD-0004q8-9i
	for qemu-devel@nongnu.org; Fri, 18 Jul 2014 05:33:06 -0400
Received: from mx.beyond.pl ([92.43.117.49]:49815)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <m.gibula@beyond.pl>) id 1X84XD-0004ps-2J
	for qemu-devel@nongnu.org; Fri, 18 Jul 2014 05:32:59 -0400
Message-ID: <53C8E9BD.4070406@beyond.pl>
Date: Fri, 18 Jul 2014 11:32:45 +0200
From: =?UTF-8?B?TWFyY2luIEdpYnXFgmE=?= <m.gibula@beyond.pl>
MIME-Version: 1.0
References: <CABYiri8_naTkFgVJEwy9O52gRYHTVGwo-6sH-r+0FOFPf0Zm8w@mail.gmail.com>	<CABYiri86MPATuKNmH489-DL3e=7=4XYi4ZVq+r=82duh1240ng@mail.gmail.com>	<CABYiri_Jb+cAty591-cmqsgxbZne-9BZeDwDOFdAm1gaKtpgzQ@mail.gmail.com>	<20140715210948.GA20036@amt.cnet>	<CABYiri9Z3iDPn1JRSR-_x4SntBZms3yQPaChSbyRFAi2W9yScw@mail.gmail.com>	<53C5A4C9.80609@redhat.com>	<CABYiri9MigkURgV273kVjhnYxLz_WnQtsZzToy531vY0cjiGkQ@mail.gmail.com>	<20140716011634.GA30717@amt.cnet>	<CABYiri96UbyO238wYKz9OC5Tn69jZ7XdaoEX1A2ucbPTrbA1tg@mail.gmail.com>	<20140716115229.GA7741@amt.cnet>	<CABYiri9mNpaY35EVGLTjR6c7SkY2HgttpN_3NihFy2jcOQ9raQ@mail.gmail.com>	<CABYiri_vDLR=PATk1Lb99nDcJf4Q-yajayyMR1Tuv6bfwVUjgQ@mail.gmail.com>	<53C6EE7C.60702@beyond.pl>	<CABYiri8HdQhsoaf2=FHLG+KyrNj05FT015bNcEk9ngH
	6Dxo7dQ@mail.gmail.com>	<53C79C41.4000800@beyond.pl>	<53C7B989.9000203@beyond.pl>	<CABYiri-aeP=0NcKaoaa=_au9sruvxnPVNri_Vy2KxKFHRj2fUw@mail.gmail.com>
	<53C7CEE5.4080006@beyond.pl> <53C8DF68.5040705@redhat.com>
In-Reply-To: <53C8DF68.5040705@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Andrey Korolyov <andrey@xdel.ru>
Cc: Amit Shah <amit.shah@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Fam Zheng <famz@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

> The name of the hack^Wfunction is tricky, because compared to
> do_kvm_cpu_synchronize_state there are three things you change:
>
> 1) you always synchronize the state
>
> 2) the next call to do_kvm_cpu_synchronize_state will do
> kvm_arch_get_registers

Yes.

> 3) the next CPU entry will call kvm_arch_put_registers:
>
>          if (cpu->kvm_vcpu_dirty) {
>              kvm_arch_put_registers(cpu, KVM_PUT_RUNTIME_STATE);
>              cpu->kvm_vcpu_dirty = false;
>          }

But, I don't set cpu->kvm_vcpu_dirty anywhere (?).

> I still lean very much towards reverting the patches now.  We can
> reapply them, fixed, in 2.1.1.

That's probably good idea.

-- 
mg