From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 18 Jul 2014 12:05:50 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:61222 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6861334AbaGRKFrxG0ge (ORCPT ); Fri, 18 Jul 2014 12:05:47 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 6B6D43427808F; Fri, 18 Jul 2014 11:05:39 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 18 Jul 2014 11:05:41 +0100 Received: from [192.168.154.109] (192.168.154.109) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 18 Jul 2014 11:05:40 +0100 Message-ID: <53C8F174.70603@imgtec.com> Date: Fri, 18 Jul 2014 11:05:40 +0100 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Jeffrey Deans , Sergei Shtylyov , Subject: Re: [PATCH 7/7] MIPS: GIC: Fix GICBIS macro References: <1405585259-24941-1-git-send-email-markos.chandras@imgtec.com> <1405585259-24941-8-git-send-email-markos.chandras@imgtec.com> <53C7C5E2.1020307@cogentembedded.com> <53C8D2AE.3020300@imgtec.com> In-Reply-To: <53C8D2AE.3020300@imgtec.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.109] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 41311 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 07/18/2014 08:54 AM, Jeffrey Deans wrote: > >> >>> + data &= ~(mask); \ >>> + data |= ((bits) & (mask)); \ >> >> Outer () not needed. > > Agreed. > Thanks for the review. This is a minor fix and I see no reason for v2. Ralf could you please remove the outer () when you get to apply this patch? Thanks! -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:61222 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6861334AbaGRKFrxG0ge (ORCPT ); Fri, 18 Jul 2014 12:05:47 +0200 Message-ID: <53C8F174.70603@imgtec.com> Date: Fri, 18 Jul 2014 11:05:40 +0100 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH 7/7] MIPS: GIC: Fix GICBIS macro References: <1405585259-24941-1-git-send-email-markos.chandras@imgtec.com> <1405585259-24941-8-git-send-email-markos.chandras@imgtec.com> <53C7C5E2.1020307@cogentembedded.com> <53C8D2AE.3020300@imgtec.com> In-Reply-To: <53C8D2AE.3020300@imgtec.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Jeffrey Deans , Sergei Shtylyov , linux-mips@linux-mips.org Message-ID: <20140718100540.ut-lOfcFriorcqFMdbFr63A_32BRdQaNdNFvcYsQf1I@z> On 07/18/2014 08:54 AM, Jeffrey Deans wrote: > >> >>> + data &= ~(mask); \ >>> + data |= ((bits) & (mask)); \ >> >> Outer () not needed. > > Agreed. > Thanks for the review. This is a minor fix and I see no reason for v2. Ralf could you please remove the outer () when you get to apply this patch? Thanks! -- markos