From: "Jindal, Sonika" <sonika.jindal@intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/7] Future preparation patches
Date: Fri, 18 Jul 2014 16:53:34 +0530 [thread overview]
Message-ID: <53C903B6.3060608@intel.com> (raw)
In-Reply-To: <20140718105616.GB31263@strange.amr.corp.intel.com>
On 7/18/2014 4:26 PM, Damien Lespiau wrote:
> On Fri, Jul 18, 2014 at 11:04:03AM +0530, sonika.jindal@intel.com wrote:
>> From: Sonika Jindal <sonika.jindal@intel.com>
>>
>> This series prepares future platform enabling by changing HAS_PCH_SPLIT to more
>> appropriate check since the code accessed may not have anything to do with
>> having PCH or not.
>
> Hi Sonika,
>
> HAS_PCH_SPLIT() is true for Ironlake (gen 5) as it's paired with the
> Ibex Peak PCH.
>
> In various patches, the condition needs to be INTEL_INFO(dev)->gen < 5
> then.
>
I am sorry, my understanding was that HAS_PCH_SPLIT is equivalent to
(gen > 5 && !(IS_VALLEYVIEW) )
So, is it like, HAS_PCH_SPLIT is equivalent to (gen >=5 && !(IS_VALEYVIEW))
-Sonika
next prev parent reply other threads:[~2014-07-18 11:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 5:34 [PATCH 0/7] Future preparation patches sonika.jindal
2014-07-18 5:34 ` [PATCH 1/7] drm/i915: Allowing changing of wm latencies for valid platforms sonika.jindal
2014-07-18 5:34 ` [PATCH 2/7] drm/i915: Returning the right VGA control reg for platforms sonika.jindal
2014-07-18 5:34 ` [PATCH 3/7] drm/i915: Setting legacy palette correctly for different platforms sonika.jindal
2014-07-18 5:34 ` [PATCH 4/7] drm/i915: Returning from increase/decrease of pllclock when invalid sonika.jindal
2014-07-18 5:34 ` [PATCH 5/7] drm/i915: Writing proper check for reading of pipe status reg sonika.jindal
2014-07-18 5:34 ` [PATCH 6/7] drm/i915: Replace HAS_PCH_SPLIT which incorrectly lets some platforms in sonika.jindal
2014-07-18 5:34 ` [PATCH 7/7] drm/i915: Avoid incorrect returning for some platforms sonika.jindal
2014-07-18 10:56 ` [PATCH 0/7] Future preparation patches Damien Lespiau
2014-07-18 11:23 ` Jindal, Sonika [this message]
2014-07-18 13:04 ` Damien Lespiau
2014-07-18 13:30 ` Daniel Vetter
2014-07-21 5:46 ` Jindal, Sonika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C903B6.3060608@intel.com \
--to=sonika.jindal@intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.