Re: [Qemu-devel] [PATCH v4 2/8] RunState: added two new flags for bitmap dump and migration process

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]

On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote:
> Changed those files that were directly using the RUN_STATE_RUNNING flag. Now,
> they have been replaced by the runstate_is_running() function.
> 
> Signed-off-by: Sanidhya Kashyap <sanidhya.iiith@gmail.com>
> ---
>  hw/usb/hcd-ehci.c |  2 +-
>  hw/usb/redirect.c |  6 +++---
>  qapi-schema.json  |  7 ++++++-
>  vl.c              | 29 ++++++++++++++++++++++++++++-
>  4 files changed, 38 insertions(+), 6 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -145,12 +145,17 @@
>  # @watchdog: the watchdog action is configured to pause and has been triggered
>  #
>  # @guest-panicked: guest has been panicked as a result of guest OS panic
> +#
> +# @migrate: migration process is being executed
> +#
> +# @dump-bitmap: dump the writable working set of the guest

Please document these new flags as (since 2.2).

How does 'migrate' differ from 'inmigrate' and 'finish-migrate'?  Why do
you need to introduce 'dump-bitmap' again? How will this interact with
older libvirt that doesn't know about the state?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]