Re: [Qemu-devel] [PATCH v4 3/8] BitmapLog: bitmap dump code via QAPI framework with runstates

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]

On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote:
> Reformatted the code and added the functionality of dumping the blocks' info
> which can be read by the user when required. I have also made the block name
> length global.
> Some minor modification to the structure which is now storing all the
> information.
> 
> Signed-off-by: Sanidhya Kashyap <sanidhya.iiith@gmail.com>
> ---
>  include/exec/cpu-all.h |   4 +-
>  migration.c            |   7 ++
>  qapi-schema.json       |  18 +++
>  qmp-commands.hx        |  30 +++++
>  savevm.c               | 325 +++++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 383 insertions(+), 1 deletion(-)
> 

> +++ b/qapi-schema.json
> @@ -3485,3 +3485,21 @@
>  # Since: 2.1
>  ##
>  { 'command': 'rtc-reset-reinjection' }
> +
> +##
> +# @log-dirty-bitmap
> +#
> +# dumps the dirty bitmap to a file by logging the
> +# memory for a specified number of times with a
> +# a defined time differnce

s/differnce/difference/

> +#
> +# @filename: name of the file in which the bitmap will be saved.
> +# @epochs: number of times the memory will be logged (optional).
> +# @frequency: time difference in milliseconds between each epoch (optional).

and their default values?

When I see epoch in relation to programming, my first thought is
1970-01-01 - not something that can be plural. Would that variable be
better named 'iterations'?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]