Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

On 07/18/2014 04:56 AM, Dr. David Alan Gilbert wrote:
> * Sanidhya Kashyap (sanidhya.iiith@gmail.com) wrote:
>> Hi,
>>
>> The following patches introduce the support of the dirty bitmap logging and
>> dumping to a specified file. This patch addresses the previous issues raised
>> by David and Juan. Since, I have not received any comments on the runstates,
>> I'll keep them in the patch series.
> 
> Hi Sanidhya,
>   I've finally got around to reading through your patches.  Some general
> thoughts first, and I'll put some more detail on the patches themselves:
> 
> 1) Do you have some examples of output?
>    Can you see hot areas in the kernel or something else?
> 
> 2) 'frequency' is probably the wrong name for the parameter you have; since
> the parameter is actually the delay between epochs, where as frequency
> would imply the number of epochs/second.

Agreed, please s/frequency/period/ throughout.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]