From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X88Wc-0002BR-Eh for qemu-devel@nongnu.org; Fri, 18 Jul 2014 09:48:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X88WX-0008UH-Cv for qemu-devel@nongnu.org; Fri, 18 Jul 2014 09:48:38 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:48743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X88WX-0008U1-55 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 09:48:33 -0400 Message-ID: <53C925AE.3010404@msgid.tls.msk.ru> Date: Fri, 18 Jul 2014 17:48:30 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1405674265-24058-1-git-send-email-pbonzini@redhat.com> <1405674265-24058-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1405674265-24058-5-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= 18.07.2014 13:04, Paolo Bonzini wrote: > From: Andreas F=C3=A4rber >=20 > The current implementation depends on a configure-time generated list o= f > block modules. When any of them is absent, module_load() emits a warnin= g. >=20 > This is suboptimal because extracting code to modules was mainly done t= o > allow separate packaging of modules with intrusive dependencies. Absenc= e > of optional packages then leads to absence of modules and an error > message, which users may recognize as new and report as error. Reviewed-by: Michael Tokarev ACK! /mjt