Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging

[Sanidhya Kashyap <sanidhya.iiith@gmail.com>]

> 
> 1) Do you have some examples of output?
>    Can you see hot areas in the kernel or something else?
>

I looked at it sometimes back. I will try to provide some images (as
suggested by you earlier) to see any consistently used areas.

> 2) 'frequency' is probably the wrong name for the parameter you have; since
> the parameter is actually the delay between epochs, where as frequency
> would imply the number of epochs/second.
> 

will surely change it to period. It is pointed out by Eric too.

> 3) The change to runstates is interesting; up until now 'runstate' is really
> mostly about the state of the CPU, but by adding migration/dumping to the
> states you're trying to convey more in that single state variable; I'm not
> quite sure if this is the right thing to do or not.
> 

Is there any alternative that can allow us to execute only one of the
processes - either migration or bitmap dump. One very basic approach
that I have thought is about using a global variable but don't know
whether that is a good option or not.

Any other alternative is welcomed.

-----

Sanidhya Kashyap