All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeroen Hofstee <dasuboot@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] MAKEALL: make sure to invoke GNU Make
Date: Fri, 18 Jul 2014 20:29:10 +0200	[thread overview]
Message-ID: <53C96776.9090104@myspectrum.nl> (raw)
In-Reply-To: <1405588682-10724-3-git-send-email-yamada.m@jp.panasonic.com>

Hello Masahiro,

On 17-07-14 11:18, Masahiro Yamada wrote:
> Since the command name 'make' is not GNU Make on some platforms
> such as FreeBSD, MAKEALL should call the make via scripts/gnu_make.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>
>   MAKEALL | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/MAKEALL b/MAKEALL
> index 37ef71e..02c2f9f 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -630,14 +630,16 @@ build_target() {
>   		output_dir="${OUTPUT_PREFIX}"
>   	fi
>   
> +	GNU_MAKE=scripts/gnu_make
> +
>   	target_arch=$(get_target_arch ${target})
>   	eval cross_toolchain=\$CROSS_COMPILE_`echo $target_arch | tr '[:lower:]' '[:upper:]'`
>   	if [ "${cross_toolchain}" ] ; then
> -	    MAKE="make CROSS_COMPILE=${cross_toolchain}"
> +	    MAKE="$GNU_MAKE CROSS_COMPILE=${cross_toolchain}"
>   	elif [ "${CROSS_COMPILE}" ] ; then
> -	    MAKE="make CROSS_COMPILE=${CROSS_COMPILE}"
> +	    MAKE="$GNU_MAKE CROSS_COMPILE=${CROSS_COMPILE}"
>   	else
> -	    MAKE=make
> +	    MAKE=$GNU_MAKE
>   	fi
>   
>   	if [  "${output_dir}" != "." ] ; then

while by itself this might be correct, opt is not a POSIX command
and MAKEALL will not work at all on a BSD host. Perhaps it is
time I have a look at what buildman is....

Regards,
Jeroen

  reply	other threads:[~2014-07-18 18:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17  9:17 [U-Boot] [PATCH 0/3] Do not hard-code the command name 'make' in upper-level tools Masahiro Yamada
2014-07-17  9:18 ` [U-Boot] [PATCH 1/3] scripts: add scripts/gnu_make to not hard-code make command Masahiro Yamada
2014-07-18 18:19   ` Jeroen Hofstee
2014-07-22  3:54     ` Masahiro Yamada
2014-07-17  9:18 ` [U-Boot] [PATCH 2/3] MAKEALL: make sure to invoke GNU Make Masahiro Yamada
2014-07-18 18:29   ` Jeroen Hofstee [this message]
2014-07-19  4:41     ` Simon Glass
2014-07-17  9:18 ` [U-Boot] [PATCH 3/3] buildman: " Masahiro Yamada
2014-07-19  4:40   ` Simon Glass
2014-07-20 18:13   ` Jeroen Hofstee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C96776.9090104@myspectrum.nl \
    --to=dasuboot@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.