From: Helge Deller <deller@gmx.de>
To: Nicholas Krause <xerofoify@gmail.com>, jejb@parisc-linux.org
Cc: tiwai@suse.de, jkosina@suse.cz, joe@perches.com,
dave.anglin@bell.net, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: Remove FIXME comment
Date: Fri, 18 Jul 2014 22:49:36 +0200 [thread overview]
Message-ID: <53C98860.2010905@gmx.de> (raw)
In-Reply-To: <1405715823-17492-1-git-send-email-xerofoify@gmail.com>
On 07/18/2014 10:37 PM, Nicholas Krause wrote:
> The comment for size of frame not being needed is incorrect , the
> function called needs this parameter.
Thanks for the patch Nicholas.
It has been queued up:
https://patchwork.kernel.org/patch/4587631/
and
https://patchwork.kernel.org/patch/4486231/
I will apply it at some point, but not yet.
There are other (more important) patches upcoming regarding the
signal handling, and I don't want to break those at the moment.
Helge
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/parisc/kernel/signal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c
> index 1cba8f2..1d550b5 100644
> --- a/arch/parisc/kernel/signal.c
> +++ b/arch/parisc/kernel/signal.c
> @@ -240,7 +240,6 @@ setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
> #endif
>
> usp = (regs->gr[30] & ~(0x01UL));
> - /*FIXME: frame_size parameter is unused, remove it. */
> frame = get_sigframe(ka, usp, sizeof(*frame));
>
> DBG(1,"SETUP_RT_FRAME: START\n");
>
next prev parent reply other threads:[~2014-07-18 20:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 20:37 [PATCH] parisc: Remove FIXME comment Nicholas Krause
2014-07-18 20:49 ` Helge Deller [this message]
2014-07-18 21:03 ` James Bottomley
2014-07-19 2:25 ` Nick Krause
2014-07-19 5:20 ` James Bottomley
2014-07-19 5:28 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C98860.2010905@gmx.de \
--to=deller@gmx.de \
--cc=dave.anglin@bell.net \
--cc=jejb@parisc-linux.org \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.