From mboxrd@z Thu Jan 1 00:00:00 1970 From: poma Subject: Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330() Date: Fri, 18 Jul 2014 23:32:51 +0200 Message-ID: <53C99283.1010107@gmail.com> References: <53C8DF7F.5060707@gmail.com> <53C8FD95.5020302@gmail.com> <20140718132104.GK27940@esperanza> <20140718141747.GA23272@lst.de> <53C97D34.5040707@gmail.com> <1405714046.30262.10.camel@dabdike.int.hansenpartnership.com> <53C9808F.5040906@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <53C9808F.5040906-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-bounces-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org Errors-To: kernel-bounces-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org To: James Bottomley Cc: Vladimir Davydov , linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mailing-List fedora-kernel , Linux Kernel list , Paolo Bonzini , Christoph Lameter , Christoph Hellwig List-Id: linux-scsi@vger.kernel.org T24gMTguMDcuMjAxNCAyMjoxNiwgcG9tYSB3cm90ZToKPiBPbiAxOC4wNy4yMDE0IDIyOjA3LCBK YW1lcyBCb3R0b21sZXkgd3JvdGU6Cj4+IE9uIEZyaSwgMjAxNC0wNy0xOCBhdCAyMjowMSArMDIw MCwgcG9tYSB3cm90ZToKPj4+IE9uIDE4LjA3LjIwMTQgMTY6MTcsIENocmlzdG9waCBIZWxsd2ln IHdyb3RlOgo+Pj4+IE9uIEZyaSwgSnVsIDE4LCAyMDE0IGF0IDA1OjIxOjA0UE0gKzA0MDAsIFZs YWRpbWlyIERhdnlkb3Ygd3JvdGU6Cj4+Pj4+IFNsYWIgd2FybnMsIGJlY2F1c2UgdGhlIG5hbWUg b2YgdGhlIGNhY2hlIGJlaW5nIGNyZWF0ZWQgY29udGFpbnMgc3BhY2VzLgo+Pj4+PiBUaGUgImJh ZCIgY2FjaGUgaXMgY3JlYXRlZCBieSBzY3NpX2dldF9ob3N0X2NtZF9wb29sLiBJdHMgbmFtZQo+ Pj4+PiAocG9vbC0+Y21kX25hbWUpIGlzIGluaXRpYWxpemVkIGJ5IHNjc2lfYWxsb2NfaG9zdF9j bWRfcG9vbCBhcyBmb2xsb3dzOgo+Pj4+Pgo+Pj4+PiAJcG9vbC0+Y21kX25hbWUgPSBrYXNwcmlu dGYoR0ZQX0tFUk5FTCwgIiVzX2NtZCIsIGhvc3R0LT5uYW1lKTsKPj4+Pj4KPj4+Pj4gU28sIGlm IGhvc3R0LT5uYW1lIGNvbnRhaW5zIHNwYWNlcywgdGhlIGNhY2hlIG5hbWUgd2lsbCBhbHNvIGNv bnRhaW4KPj4+Pj4gc3BhY2VzIGFuZCB3ZSdsbCBnZXQgdGhlIHdhcm5pbmcuIEFuZCBob3N0dC0+ bmFtZSBjYW4gY29udGFpbiBzcGFjZXMsCj4+Pj4+IGUuZy4gdmlydHNjc2lfaG9zdF90ZW1wbGF0 ZV9zaW5nbGUubmFtZT0iVmlydGlvIFNDU0kgSEJBIi4KPj4+Pgo+Pj4+IE9yIG1pZ2h0IG5vdCBl dmVuIGJlIHByZXNlbnQuICBJJ2xsIHNlbmQgYSBwYXRjaCB0byByZXBsYWNlIGl0IHdpdGgKPj4+ PiAtPnByb2NfbmFtZSwgd2hpY2ggbXVzdCBub3QgY29udGFpbiBzcGFjZXMgYW5kIGlzIGdlbmVy YWxseSBzaG9ydGVyCj4+Pj4gYXMgd2VsbC4KPj4+Pgo+Pj4KPj4+IElzIHRoaXMgd2hhdCB5b3Ug dGhvdWdodD8KPj4KPj4gTm8sIGhlIG1lYW5zIHRoaXMsIGlmIHlvdSB3YW50IHRvIHRyeSBpdC4K Pj4KPj4gSmFtZXMKPj4KPj4gLS0tCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Njc2kvc2Nz aS5jIGIvZHJpdmVycy9zY3NpL3Njc2kuYwo+PiBpbmRleCA4OGQ0NmZlLi5lYjA3YTliIDEwMDY0 NAo+PiAtLS0gYS9kcml2ZXJzL3Njc2kvc2NzaS5jCj4+ICsrKyBiL2RyaXZlcnMvc2NzaS9zY3Np LmMKPj4gQEAgLTM2OCw4ICszNjgsOCBAQCBzY3NpX2FsbG9jX2hvc3RfY21kX3Bvb2woc3RydWN0 IFNjc2lfSG9zdCAqc2hvc3QpCj4+ICAgIAlpZiAoIXBvb2wpCj4+ICAgIAkJcmV0dXJuIE5VTEw7 Cj4+Cj4+IC0JcG9vbC0+Y21kX25hbWUgPSBrYXNwcmludGYoR0ZQX0tFUk5FTCwgIiVzX2NtZCIs IGhvc3R0LT5uYW1lKTsKPj4gLQlwb29sLT5zZW5zZV9uYW1lID0ga2FzcHJpbnRmKEdGUF9LRVJO RUwsICIlc19zZW5zZSIsIGhvc3R0LT5uYW1lKTsKPj4gKwlwb29sLT5jbWRfbmFtZSA9IGthc3By aW50ZihHRlBfS0VSTkVMLCAiJXNfY21kIiwgaG9zdHQtPnByb2NfbmFtZSk7Cj4+ICsJcG9vbC0+ c2Vuc2VfbmFtZSA9IGthc3ByaW50ZihHRlBfS0VSTkVMLCAiJXNfc2Vuc2UiLCBob3N0dC0+cHJv Y19uYW1lKTsKPj4gICAgCWlmICghcG9vbC0+Y21kX25hbWUgfHwgIXBvb2wtPnNlbnNlX25hbWUp IHsKPj4gICAgCQlzY3NpX2ZyZWVfaG9zdF9jbWRfcG9vbChwb29sKTsKPj4gICAgCQlyZXR1cm4g TlVMTDsKPj4KPj4KPgo+IE1hbiwgSSBqdXN0IG5vdyByZWFkIGl0IGNvcnJlY3RseSAtICJTbywg aWYgaG9zdHQtPm5hbWUgY29udGFpbnMgc3BhY2VzIi4KPiBUaGFua3MuCj4KPiBJJ2xsIGJlIGJh Y2suCj4KClllYSwgSSBjYW4gY29uZmlybSBpdCB3b3JrcyEgOikKTm8gd2FybmluZ3MuCgoKcG9t YQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtlcm5l bCBtYWlsaW5nIGxpc3QKa2VybmVsQGxpc3RzLmZlZG9yYXByb2plY3Qub3JnCmh0dHBzOi8vYWRt aW4uZmVkb3JhcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXJuZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755092AbaGRVc4 (ORCPT ); Fri, 18 Jul 2014 17:32:56 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:45556 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753425AbaGRVcz (ORCPT ); Fri, 18 Jul 2014 17:32:55 -0400 Message-ID: <53C99283.1010107@gmail.com> Date: Fri, 18 Jul 2014 23:32:51 +0200 From: poma User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: James Bottomley CC: Christoph Hellwig , Vladimir Davydov , Linux Kernel list , Christoph Lameter , Mailing-List fedora-kernel , Paolo Bonzini , linux-scsi@vger.kernel.org Subject: Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330() References: <53C8DF7F.5060707@gmail.com> <53C8FD95.5020302@gmail.com> <20140718132104.GK27940@esperanza> <20140718141747.GA23272@lst.de> <53C97D34.5040707@gmail.com> <1405714046.30262.10.camel@dabdike.int.hansenpartnership.com> <53C9808F.5040906@gmail.com> In-Reply-To: <53C9808F.5040906@gmail.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.07.2014 22:16, poma wrote: > On 18.07.2014 22:07, James Bottomley wrote: >> On Fri, 2014-07-18 at 22:01 +0200, poma wrote: >>> On 18.07.2014 16:17, Christoph Hellwig wrote: >>>> On Fri, Jul 18, 2014 at 05:21:04PM +0400, Vladimir Davydov wrote: >>>>> Slab warns, because the name of the cache being created contains spaces. >>>>> The "bad" cache is created by scsi_get_host_cmd_pool. Its name >>>>> (pool->cmd_name) is initialized by scsi_alloc_host_cmd_pool as follows: >>>>> >>>>> pool->cmd_name = kasprintf(GFP_KERNEL, "%s_cmd", hostt->name); >>>>> >>>>> So, if hostt->name contains spaces, the cache name will also contain >>>>> spaces and we'll get the warning. And hostt->name can contain spaces, >>>>> e.g. virtscsi_host_template_single.name="Virtio SCSI HBA". >>>> >>>> Or might not even be present. I'll send a patch to replace it with >>>> ->proc_name, which must not contain spaces and is generally shorter >>>> as well. >>>> >>> >>> Is this what you thought? >> >> No, he means this, if you want to try it. >> >> James >> >> --- >> >> diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c >> index 88d46fe..eb07a9b 100644 >> --- a/drivers/scsi/scsi.c >> +++ b/drivers/scsi/scsi.c >> @@ -368,8 +368,8 @@ scsi_alloc_host_cmd_pool(struct Scsi_Host *shost) >> if (!pool) >> return NULL; >> >> - pool->cmd_name = kasprintf(GFP_KERNEL, "%s_cmd", hostt->name); >> - pool->sense_name = kasprintf(GFP_KERNEL, "%s_sense", hostt->name); >> + pool->cmd_name = kasprintf(GFP_KERNEL, "%s_cmd", hostt->proc_name); >> + pool->sense_name = kasprintf(GFP_KERNEL, "%s_sense", hostt->proc_name); >> if (!pool->cmd_name || !pool->sense_name) { >> scsi_free_host_cmd_pool(pool); >> return NULL; >> >> > > Man, I just now read it correctly - "So, if hostt->name contains spaces". > Thanks. > > I'll be back. > Yea, I can confirm it works! :) No warnings. poma