All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Thomas Abraham <thomas.ab@samsung.com>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org, mturquette@linaro.org,
	kgene.kim@samsung.com, t.figa@samsung.com,
	l.majewski@samsung.com, viresh.kumar@linaro.org, heiko@sntech.de,
	cw00.choi@samsung.com
Subject: Re: [PATCH v7 6/6] cpufreq: exynos: remove exynos4210/5250 specific cpufreq driver support
Date: Sat, 19 Jul 2014 15:29:48 +0200	[thread overview]
Message-ID: <53CA72CC.7010505@gmail.com> (raw)
In-Reply-To: <1405345118-4269-7-git-send-email-thomas.ab@samsung.com>

Hi,

On 14.07.2014 15:38, Thomas Abraham wrote:
> From: Thomas Abraham <thomas.ab@samsung.com>
> 
> Exynos4210 and Exynos5250 based platforms have switched over to use generic
> cpufreq drivers for cpufreq functionality. So the Exynos specific cpufreq
> drivers for these platforms can be removed.
> 
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Reviewed-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
> Tested-by: Arjun K.V <arjun.kv@samsung.com>
> ---
>  drivers/cpufreq/Kconfig.arm          |   22 ----
>  drivers/cpufreq/Makefile             |    2 -
>  drivers/cpufreq/exynos4210-cpufreq.c |  184 -----------------------------
>  drivers/cpufreq/exynos5250-cpufreq.c |  210 ----------------------------------
>  4 files changed, 418 deletions(-)
>  delete mode 100644 drivers/cpufreq/exynos4210-cpufreq.c
>  delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c
> 

I would hesitate with removing this driver straightaway and replacing it
with a new one that isn't yet well tested. For at least one release I
would keep the old code in place with the possibility of switching
between old and new one in Kconfig.

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 6/6] cpufreq: exynos: remove exynos4210/5250 specific cpufreq driver support
Date: Sat, 19 Jul 2014 15:29:48 +0200	[thread overview]
Message-ID: <53CA72CC.7010505@gmail.com> (raw)
In-Reply-To: <1405345118-4269-7-git-send-email-thomas.ab@samsung.com>

Hi,

On 14.07.2014 15:38, Thomas Abraham wrote:
> From: Thomas Abraham <thomas.ab@samsung.com>
> 
> Exynos4210 and Exynos5250 based platforms have switched over to use generic
> cpufreq drivers for cpufreq functionality. So the Exynos specific cpufreq
> drivers for these platforms can be removed.
> 
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Reviewed-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
> Tested-by: Arjun K.V <arjun.kv@samsung.com>
> ---
>  drivers/cpufreq/Kconfig.arm          |   22 ----
>  drivers/cpufreq/Makefile             |    2 -
>  drivers/cpufreq/exynos4210-cpufreq.c |  184 -----------------------------
>  drivers/cpufreq/exynos5250-cpufreq.c |  210 ----------------------------------
>  4 files changed, 418 deletions(-)
>  delete mode 100644 drivers/cpufreq/exynos4210-cpufreq.c
>  delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c
> 

I would hesitate with removing this driver straightaway and replacing it
with a new one that isn't yet well tested. For at least one release I
would keep the old code in place with the possibility of switching
between old and new one in Kconfig.

Best regards,
Tomasz

  reply	other threads:[~2014-07-19 13:29 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 13:38 [PATCH v7 0/6] cpufreq: use generic cpufreq drivers for exynos platforms Thomas Abraham
2014-07-14 13:38 ` Thomas Abraham
2014-07-14 13:38 ` [PATCH v7 1/6] clk: samsung: add infrastructure to register cpu clocks Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 12:55   ` Tomasz Figa
2014-07-19 12:55     ` Tomasz Figa
2014-07-29  5:35     ` Thomas Abraham
2014-07-29  5:35       ` Thomas Abraham
2014-07-29  9:57       ` Tomasz Figa
2014-07-29  9:57         ` Tomasz Figa
2014-07-14 13:38 ` [PATCH v7 2/6] clk: samsung: register exynos5420 apll/kpll configuration data Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 12:57   ` Tomasz Figa
2014-07-19 12:57     ` Tomasz Figa
2014-07-14 13:38 ` [PATCH v7 3/6] clk: exynos: use cpu-clock provider type to represent arm clock Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 13:06   ` Tomasz Figa
2014-07-19 13:06     ` Tomasz Figa
2014-07-14 13:38 ` [PATCH v7 4/6] ARM: dts: Exynos: add cpu nodes, opp and cpu clock configuration data Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 13:18   ` Tomasz Figa
2014-07-19 13:18     ` Tomasz Figa
2014-07-29  5:36     ` Thomas Abraham
2014-07-29  5:36       ` Thomas Abraham
2014-07-14 13:38 ` [PATCH v7 5/6] ARM: Exynos: switch to using generic cpufreq driver for exynos4210/5250/5420 Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 13:27   ` Tomasz Figa
2014-07-19 13:27     ` Tomasz Figa
2014-07-29  5:37     ` Thomas Abraham
2014-07-29  5:37       ` Thomas Abraham
2014-07-14 13:38 ` [PATCH v7 6/6] cpufreq: exynos: remove exynos4210/5250 specific cpufreq driver support Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 13:29   ` Tomasz Figa [this message]
2014-07-19 13:29     ` Tomasz Figa
2014-07-29  5:53     ` Thomas Abraham
2014-07-29  5:53       ` Thomas Abraham
2014-07-15  3:50 ` [PATCH v7 0/6] cpufreq: use generic cpufreq drivers for exynos platforms Thomas Abraham
2014-07-15  3:50   ` Thomas Abraham
2014-07-17  5:58   ` Thomas Abraham
2014-07-17  5:58     ` Thomas Abraham
2014-07-18  0:44     ` Chanwoo Choi
2014-07-18  0:44       ` Chanwoo Choi
2014-07-18  2:04       ` Thomas Abraham
2014-07-18  2:04         ` Thomas Abraham
2014-07-19 19:20 ` Tobias Jakobi
2014-07-19 19:20   ` Tobias Jakobi
2014-07-19 20:54   ` Tomasz Figa
2014-07-19 20:54     ` Tomasz Figa
2014-07-19 21:17     ` Tobias Jakobi
2014-07-19 21:17       ` Tobias Jakobi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CA72CC.7010505@gmail.com \
    --to=tomasz.figa@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=heiko@sntech.de \
    --cc=kgene.kim@samsung.com \
    --cc=l.majewski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=t.figa@samsung.com \
    --cc=thomas.ab@samsung.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.