From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Cc: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
Subject: Re: [PATCH 02/13] iio:bma180: Missing check for frequency fractional part
Date: Sun, 20 Jul 2014 17:41:33 +0100 [thread overview]
Message-ID: <53CBF13D.7010308@kernel.org> (raw)
In-Reply-To: <1405535576-26482-3-git-send-email-pmeerw@pmeerw.net>
On 16/07/14 19:32, Peter Meerwald wrote:
> val2 should be zero
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
I added a bit more explanation to the the description of what the actual
result was.
> ---
> drivers/iio/accel/bma180.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> index 28388bb..a077cc8 100644
> --- a/drivers/iio/accel/bma180.c
> +++ b/drivers/iio/accel/bma180.c
> @@ -376,6 +376,8 @@ static int bma180_write_raw(struct iio_dev *indio_dev,
> mutex_unlock(&data->mutex);
> return ret;
> case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY:
> + if (val2)
> + return -EINVAL;
> mutex_lock(&data->mutex);
> ret = bma180_set_bw(data, val);
> mutex_unlock(&data->mutex);
>
next prev parent reply other threads:[~2014-07-20 16:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 18:32 [PATCH 00/13] iio:bma180: Fixes and BMA250 support Peter Meerwald
2014-07-16 18:32 ` [PATCH 01/13] iio:bma180: Fix scale factors to report correct acceleration units Peter Meerwald
2014-07-20 16:39 ` Jonathan Cameron
2014-07-16 18:32 ` [PATCH 02/13] iio:bma180: Missing check for frequency fractional part Peter Meerwald
2014-07-20 16:41 ` Jonathan Cameron [this message]
2014-07-16 18:32 ` [PATCH 03/13] iio:bma180: Enable use of device without IRQ Peter Meerwald
2014-07-16 18:32 ` [PATCH 04/13] iio:bma180: Prefix remaining tables and functions with bma18_ Peter Meerwald
2014-07-16 18:32 ` [PATCH 05/13] iio:bma180: Rename BMA_180 to BMA180_ Peter Meerwald
2014-07-16 18:32 ` [PATCH 06/13] iio:bma180: Use bool instead of int for state Peter Meerwald
2014-07-16 18:32 ` [PATCH 07/13] iio:bma180: Expose temperature channel Peter Meerwald
2014-07-16 18:32 ` [PATCH 08/13] iio:bma180: Drop _update_scan_mode() Peter Meerwald
2014-07-16 18:32 ` [PATCH 09/13] iio:bma180: Introduce part_info to differentiate further chip variants Peter Meerwald
2014-07-16 18:32 ` [PATCH 10/13] iio:bma180: Introduce part-specific _config() and disable() code Peter Meerwald
2014-07-16 18:32 ` [PATCH 11/13] iio:bma180: Prepare for accelerometer channels with different resolutions Peter Meerwald
2014-07-16 18:32 ` [PATCH 12/13] iio:bma180: Implement _available sysfs attribute dynamically Peter Meerwald
2014-07-16 18:32 ` [PATCH 13/13] iio:bma180: Add BMA250 chip support Peter Meerwald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CBF13D.7010308@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=o.v.kravchenko@globallogic.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.