All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq: bitmap tag: fix potential unwakeable sleep in bt_get()
Date: Mon, 21 Jul 2014 10:34:20 +0200	[thread overview]
Message-ID: <53CCD08C.80702@kernel.dk> (raw)
In-Reply-To: <20140721083202.GA2107@dhcp-26-207.brq.redhat.com>

On 2014-07-21 10:32, Alexander Gordeev wrote:
> On Mon, Jul 21, 2014 at 10:16:54AM +0200, Jens Axboe wrote:
>> What is this patch against?
>
> v3.16-rc5

My bad, was looking at the wrong sources. What is the race? If the clear 
and wakeup come in after the prepare_to_wait() but before the 
io_schedule(), the io_schedule() will be a no-op and it wont actually 
sleep. Your commit message doesn't mention any particular details.


-- 
Jens Axboe


  reply	other threads:[~2014-07-21  8:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21  8:10 [PATCH] blk-mq: bitmap tag: fix potential unwakeable sleep in bt_get() Alexander Gordeev
2014-07-21  8:16 ` Jens Axboe
2014-07-21  8:32   ` Alexander Gordeev
2014-07-21  8:34     ` Jens Axboe [this message]
2014-07-21  9:11       ` Alexander Gordeev
2014-07-22  8:27         ` Alexander Gordeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CCD08C.80702@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=agordeev@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.