From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: stubdom/libxc-x86_64 compile error with valgrind installed Date: Mon, 21 Jul 2014 11:56:26 +0100 Message-ID: <53CCF1DA.3030604@citrix.com> References: <1216211935.20140721110014@gmail.com> <53CCE922.9080109@citrix.com> <1405938788.24518.3.camel@kazak.uk.xensource.com> <53CCEE37.80903@citrix.com> <1405939668.25022.8.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1405939668.25022.8.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Ian Jackson Cc: Simon Martin , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 21/07/14 11:47, Ian Campbell wrote: > On Mon, 2014-07-21 at 11:40 +0100, Andrew Cooper wrote: >> On 21/07/14 11:33, Ian Campbell wrote: >>> On Mon, 2014-07-21 at 11:19 +0100, Andrew Cooper wrote: >>>> I am not sure what is the correct solution here is. Introducing an >>>> explicit --{en,dis}able-valgrind to the main ./configure will still >>>> break for anyone who chooses to enable it. >>> I proposed a bodge which I think would be acceptable (assuming it works) >> I saw. It most certainly is a bodge, but is probably the best short >> term course of action. >> >> Doesn't it need an extra check for the rump stuff? > I don't know... > > Ian, the proposal is tools/libxc/xc_private.h: > -#if defined(HAVE_VALGRIND_MEMCHECK_H) && !defined(NDEBUG) > +#if defined(HAVE_VALGRIND_MEMCHECK_H) && !defined(NDEBUG) && !defined(__MINIOS__) > > Ian. > Nor do I, but IanJ's series changed most (all?) the #if !defined(__MINIOS__) into #if !defined(__MINIOS__) || !defined(__RUMPUSER_XEN__) Therefore, I suspect the same is needed here. ~Andrew