Re: [PATCH] skbedit: allow the user to specify bitmask for mark

[Antonio Quartulli <antonio@open-mesh.com>]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]



On 21/07/14 14:31, Eric Dumazet wrote:
> On Mon, 2014-07-21 at 10:35 +0200, Antonio Quartulli wrote:
>> From: Antonio Quartulli <antonio@open-mesh.com>
>>
>> The user may want to use only some bits of the skb mark in
>> his skbedit rules because the remaining part might be used by
>> something else.
>>
>> Introduce the "mask" parameter to the skbedit actor in order
>> to implement such functionality.
>>
>> When the mask is specified, only those bits selected by the
>> latter are altered really changed by the actor, while the
>> rest is left untouched.
>>
>> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
>> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
>> ---
>>  include/net/tc_act/tc_skbedit.h        |  1 +
>>  include/uapi/linux/tc_act/tc_skbedit.h |  2 ++
>>  net/sched/act_skbedit.c                | 20 +++++++++++++++++---
>>  3 files changed, 20 insertions(+), 3 deletions(-)
> 
> 
> You forgot to update tcf_skbedit_dump()
> 

Oh right! Thanks Eric.
I'll send v2

-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]