From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Chen Gang <gang.chen.5i5j@gmail.com>, tglx@linutronix.de
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liqin Chen <liqin.linux@gmail.com>,
Lennox Wu <lennox.wu@gmail.com>
Subject: Re: [PATCH] drivers: clocksource: Kconfig: Let EM_TIMER_STI depend on HAS_IOMEM
Date: Mon, 21 Jul 2014 16:45:34 +0200 [thread overview]
Message-ID: <53CD278E.3080300@linaro.org> (raw)
In-Reply-To: <53BBE68C.3010000@gmail.com>
On 07/08/2014 02:39 PM, Chen Gang wrote:
> In 'em_sti.c', it will call devm_ioremap_resource() which need
> HAS_IOMEM. So need let EM_TIMER_STI depend on HAS_IOMEM, too.
>
> The related error (with allmodconfig under score):
>
> LD init/built-in.o
> em_sti.c:(.text.em_sti_probe+0x84): undefined reference to `devm_ioremap_resource'
> make: *** [vmlinux] Error 1
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/clocksource/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 8ad1eac..ce372d6 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -190,7 +190,7 @@ config SH_TIMER_TMU
>
> config EM_TIMER_STI
> bool "Renesas STI timer driver" if COMPILE_TEST
> - depends on GENERIC_CLOCKEVENTS
> + depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
> default SYS_SUPPORTS_EM_STI
> help
> This enables build of a clocksource and clockevent driver for
Applied to my tree for 3.17
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2014-07-21 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 12:39 [PATCH] drivers: clocksource: Kconfig: Let EM_TIMER_STI depend on HAS_IOMEM Chen Gang
2014-07-21 14:45 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CD278E.3080300@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=gang.chen.5i5j@gmail.com \
--cc=lennox.wu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liqin.linux@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.