From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 21 Jul 2014 17:19:54 +0000 Subject: Re: [PATCH v2 1/7] memory-hotplug: add zone_for_memory() for selecting zone for new memory Message-Id: <53CD4BBA.1050706@cogentembedded.com> List-Id: References: <1405914402-66212-1-git-send-email-wangnan0@huawei.com> <1405914402-66212-2-git-send-email-wangnan0@huawei.com> In-Reply-To: <1405914402-66212-2-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wang Nan , Ingo Molnar , Yinghai Lu , Mel Gorman , Andrew Morton , Dave Hansen , Zhang Yanfei Cc: peifeiyue@huawei.com, linux-mm@kvack.org, x86@kernel.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Hello. On 07/21/2014 07:46 AM, Wang Nan wrote: Some grammar nitpicking. > This patch introduces a zone_for_memory function in arch independent > code for arch_add_memory() using. s/ using/'s use/. > Many arch_add_memory() function simply selects ZONE_HIGHMEM or Plural needed with "many". > ZONE_NORMAL and add new memory into it. However, with the existance of > ZONE_MOVABLE, the selection method should be carefully considered: if > new, higher memory is added after ZONE_MOVABLE is setup, the default > zone and ZONE_MOVABLE may overlap each other. > should_add_memory_movable() checks the status of ZONE_MOVABLE. If it has > already contain memory, compare the address of new memory and movable > memory. If new memory is higher than movable, it should be added into > ZONE_MOVABLE instead of default zone. > Signed-off-by: Wang Nan > Cc: Zhang Yanfei > Cc: Dave Hansen [...] > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 469bbf5..348fda7 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1156,6 +1156,34 @@ static int check_hotplug_memory_range(u64 start, u64 size) > return 0; > } > > +/* > + * If movable zone has already been setup, newly added memory should be check. Checked. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-f44.google.com (mail-la0-f44.google.com [209.85.215.44]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 11BD51A01EE for ; Tue, 22 Jul 2014 03:20:02 +1000 (EST) Received: by mail-la0-f44.google.com with SMTP id e16so5036299lan.31 for ; Mon, 21 Jul 2014 10:19:57 -0700 (PDT) Message-ID: <53CD4BBA.1050706@cogentembedded.com> Date: Mon, 21 Jul 2014 21:19:54 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Wang Nan , Ingo Molnar , Yinghai Lu , Mel Gorman , Andrew Morton , Dave Hansen , Zhang Yanfei Subject: Re: [PATCH v2 1/7] memory-hotplug: add zone_for_memory() for selecting zone for new memory References: <1405914402-66212-1-git-send-email-wangnan0@huawei.com> <1405914402-66212-2-git-send-email-wangnan0@huawei.com> In-Reply-To: <1405914402-66212-2-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linux-ia64@vger.kernel.org, peifeiyue@huawei.com, linux-sh@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello. On 07/21/2014 07:46 AM, Wang Nan wrote: Some grammar nitpicking. > This patch introduces a zone_for_memory function in arch independent > code for arch_add_memory() using. s/ using/'s use/. > Many arch_add_memory() function simply selects ZONE_HIGHMEM or Plural needed with "many". > ZONE_NORMAL and add new memory into it. However, with the existance of > ZONE_MOVABLE, the selection method should be carefully considered: if > new, higher memory is added after ZONE_MOVABLE is setup, the default > zone and ZONE_MOVABLE may overlap each other. > should_add_memory_movable() checks the status of ZONE_MOVABLE. If it has > already contain memory, compare the address of new memory and movable > memory. If new memory is higher than movable, it should be added into > ZONE_MOVABLE instead of default zone. > Signed-off-by: Wang Nan > Cc: Zhang Yanfei > Cc: Dave Hansen [...] > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 469bbf5..348fda7 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1156,6 +1156,34 @@ static int check_hotplug_memory_range(u64 start, u64 size) > return 0; > } > > +/* > + * If movable zone has already been setup, newly added memory should be check. Checked. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-f51.google.com (mail-la0-f51.google.com [209.85.215.51]) by kanga.kvack.org (Postfix) with ESMTP id 8D8E56B0055 for ; Mon, 21 Jul 2014 13:20:02 -0400 (EDT) Received: by mail-la0-f51.google.com with SMTP id el20so4923162lab.38 for ; Mon, 21 Jul 2014 10:20:00 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com [209.85.215.41]) by mx.google.com with ESMTPS id en6si26168816lac.93.2014.07.21.10.19.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 21 Jul 2014 10:19:57 -0700 (PDT) Received: by mail-la0-f41.google.com with SMTP id s18so5084343lam.0 for ; Mon, 21 Jul 2014 10:19:57 -0700 (PDT) Message-ID: <53CD4BBA.1050706@cogentembedded.com> Date: Mon, 21 Jul 2014 21:19:54 +0400 From: Sergei Shtylyov MIME-Version: 1.0 Subject: Re: [PATCH v2 1/7] memory-hotplug: add zone_for_memory() for selecting zone for new memory References: <1405914402-66212-1-git-send-email-wangnan0@huawei.com> <1405914402-66212-2-git-send-email-wangnan0@huawei.com> In-Reply-To: <1405914402-66212-2-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Wang Nan , Ingo Molnar , Yinghai Lu , Mel Gorman , Andrew Morton , Dave Hansen , Zhang Yanfei Cc: peifeiyue@huawei.com, linux-mm@kvack.org, x86@kernel.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Hello. On 07/21/2014 07:46 AM, Wang Nan wrote: Some grammar nitpicking. > This patch introduces a zone_for_memory function in arch independent > code for arch_add_memory() using. s/ using/'s use/. > Many arch_add_memory() function simply selects ZONE_HIGHMEM or Plural needed with "many". > ZONE_NORMAL and add new memory into it. However, with the existance of > ZONE_MOVABLE, the selection method should be carefully considered: if > new, higher memory is added after ZONE_MOVABLE is setup, the default > zone and ZONE_MOVABLE may overlap each other. > should_add_memory_movable() checks the status of ZONE_MOVABLE. If it has > already contain memory, compare the address of new memory and movable > memory. If new memory is higher than movable, it should be added into > ZONE_MOVABLE instead of default zone. > Signed-off-by: Wang Nan > Cc: Zhang Yanfei > Cc: Dave Hansen [...] > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 469bbf5..348fda7 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1156,6 +1156,34 @@ static int check_hotplug_memory_range(u64 start, u64 size) > return 0; > } > > +/* > + * If movable zone has already been setup, newly added memory should be check. Checked. WBR, Sergei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933243AbaGURUA (ORCPT ); Mon, 21 Jul 2014 13:20:00 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:49508 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932382AbaGURT6 (ORCPT ); Mon, 21 Jul 2014 13:19:58 -0400 Message-ID: <53CD4BBA.1050706@cogentembedded.com> Date: Mon, 21 Jul 2014 21:19:54 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Wang Nan , Ingo Molnar , Yinghai Lu , Mel Gorman , Andrew Morton , Dave Hansen , Zhang Yanfei CC: peifeiyue@huawei.com, linux-mm@kvack.org, x86@kernel.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] memory-hotplug: add zone_for_memory() for selecting zone for new memory References: <1405914402-66212-1-git-send-email-wangnan0@huawei.com> <1405914402-66212-2-git-send-email-wangnan0@huawei.com> In-Reply-To: <1405914402-66212-2-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 07/21/2014 07:46 AM, Wang Nan wrote: Some grammar nitpicking. > This patch introduces a zone_for_memory function in arch independent > code for arch_add_memory() using. s/ using/'s use/. > Many arch_add_memory() function simply selects ZONE_HIGHMEM or Plural needed with "many". > ZONE_NORMAL and add new memory into it. However, with the existance of > ZONE_MOVABLE, the selection method should be carefully considered: if > new, higher memory is added after ZONE_MOVABLE is setup, the default > zone and ZONE_MOVABLE may overlap each other. > should_add_memory_movable() checks the status of ZONE_MOVABLE. If it has > already contain memory, compare the address of new memory and movable > memory. If new memory is higher than movable, it should be added into > ZONE_MOVABLE instead of default zone. > Signed-off-by: Wang Nan > Cc: Zhang Yanfei > Cc: Dave Hansen [...] > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 469bbf5..348fda7 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1156,6 +1156,34 @@ static int check_hotplug_memory_range(u64 start, u64 size) > return 0; > } > > +/* > + * If movable zone has already been setup, newly added memory should be check. Checked. WBR, Sergei