From: Jens Axboe <axboe@kernel.dk>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: Puthikorn Voravootivat <puthik@chromium.org>, fio@vger.kernel.org
Subject: Re: [fio-2.1.9] verify and bssplit do not work together
Date: Mon, 21 Jul 2014 20:40:38 +0200 [thread overview]
Message-ID: <53CD5EA6.4090706@kernel.dk> (raw)
In-Reply-To: <CAMHSBOW1g2y9nCMQs=qJ-ggWZEG_MiG27BgpttPFsk1tdUQy5g@mail.gmail.com>
On 2014-07-21 19:49, Gwendal Grignou wrote:
> Jens,
>
> Without the patch, experimental_verify=1 produced more error, it looks
> like every 64k.
>
> With the patch above, fio behaves as expected: do_verify and
> experimental_verify works for mixed writes.
>
> There is still a problem when bs is mixed and one argument is less
> than the verify interval.
> For instance:
> bssplit=4k/50:1M/50
> ...
> verify_interval=64k
>
>
> But looking at the code, it won't be possible to fix, because we can
> not guarantee to always have 16 4K write contiguous.
As mentioned in the original email, it's a parser fix. verify_interval
cannot be less than the minimum block size, fio will just have to catch
that and adjust / error out.
> Thanks for the patch.
It's committed, so generally available now.
--
Jens Axboe
next prev parent reply other threads:[~2014-07-21 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 20:36 [fio-2.1.9] verify and bssplit do not work together Gwendal Grignou
2014-07-18 7:47 ` Jens Axboe
2014-07-21 8:29 ` Jens Axboe
2014-07-21 17:41 ` Gwendal Grignou
2014-07-21 17:49 ` Gwendal Grignou
2014-07-21 18:40 ` Jens Axboe [this message]
2014-07-21 18:52 ` Jens Axboe
2014-07-21 20:24 ` Gwendal Grignou
2014-07-21 20:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CD5EA6.4090706@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=gwendal@chromium.org \
--cc=puthik@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.