Re: [PATCH] Fix build warnings in aer.h

[Mike Qiu <qiudayu@linux.vnet.ibm.com>]

On 07/17/2014 02:08 AM, Bjorn Helgaas wrote:
> On Wed, Jul 16, 2014 at 2:08 AM, Mike Qiu <qiudayu@linux.vnet.ibm.com> wrote:
>> build log:
>>
>> In file included from include/ras/ras_event.h:11:0,
>>                   from drivers/ras/ras.c:13:
>> include/linux/aer.h:42:129: warning: ‘struct pci_dev’
>> declared inside parameter list [enabled by default]
>>
>> include/linux/aer.h:42:129: warning: its scope is only
>> this definition or declaration, which is probably not
>> what you want [enabled by default]
>>
>> include/linux/aer.h:46:130: warning: ‘struct pci_dev’
>> declared inside parameter list [enabled by default]
>>
>> include/linux/aer.h:50:136: warning: ‘struct pci_dev’
>> declared inside parameter list [enabled by default]
>>
>> include/linux/aer.h:57:14: warning: ‘struct pci_dev’
>> declared inside parameter list [enabled by default]
>>
>> Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
> Hi Mike,
>
> How did you reproduce this build error?  There are other include files
> that use pci_dev without a previous declaration or include of
> include/linux/pci.h, e.g., include/linux/msi.h, so I want to make sure
> we don't have similar problems elsewhere.
( I have reply it before but seems haven't send out successful, just 
resend it, if you have seen, pls ignore this)
I checkout to linux-next master branch, see the top commit is:

commit b997a07604562f1a54cc531fe1cf7447f0ed6078
Author: Stephen Rothwell <sfr@canb.auug.org.au>
Date:   Tue Jul 15 18:34:28 2014 +1000

     Add linux-next specific files for 20140715

     Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Use default config file(copy from /boot/) then use command "make -j60",  
and it will show that message. but for "msi.h" I haven't see this warning.

Thanks,
Mike
> Bjorn
>
>> ---
>>   include/linux/aer.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/include/linux/aer.h b/include/linux/aer.h
>> index 4dbaa70..c826d1c 100644
>> --- a/include/linux/aer.h
>> +++ b/include/linux/aer.h
>> @@ -11,6 +11,8 @@
>>   #define AER_FATAL                      1
>>   #define AER_CORRECTABLE                        2
>>
>> +struct pci_dev;
>> +
>>   struct aer_header_log_regs {
>>          unsigned int dw0;
>>          unsigned int dw1;
>> --
>> 1.8.1.4
>>