From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Nan Date: Tue, 22 Jul 2014 03:09:34 +0000 Subject: Re: [PATCH v2 7/7] memory-hotplug: tile: suitable memory should go to ZONE_MOVABLE Message-Id: <53CDD5EE.1030805@huawei.com> List-Id: References: <1405914402-66212-1-git-send-email-wangnan0@huawei.com> <1405914402-66212-8-git-send-email-wangnan0@huawei.com> In-Reply-To: <1405914402-66212-8-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: Wang Nan , Ingo Molnar , Yinghai Lu , Mel Gorman , Dave Hansen , Zhang Yanfei , peifeiyue@huawei.com, linux-mm@kvack.org, x86@kernel.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Metcalf Hi Andrew, Please drop patch 7/7 from -mm tree and keep other 6 patches. arch_add_memory() in tile is different from others: no nid parameter. Patch 7/7 will block compiling. I cc this mail to Chris Metcalf and hope he can look at this issue. Other 6 patches looks good. On 2014/7/21 11:46, Wang Nan wrote: > This patch introduces zone_for_memory() to arch_add_memory() on tile to > ensure new, higher memory added into ZONE_MOVABLE if movable zone has > already setup. > > This patch also fix a problem: on tile, new memory should be added into > ZONE_HIGHMEM by default, not MAX_NR_ZONES-1, which is ZONE_MOVABLE. > > Signed-off-by: Wang Nan > Cc: Zhang Yanfei > Cc: Dave Hansen > --- > arch/tile/mm/init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/tile/mm/init.c b/arch/tile/mm/init.c > index bfb3127..22ac6c1 100644 > --- a/arch/tile/mm/init.c > +++ b/arch/tile/mm/init.c > @@ -872,7 +872,8 @@ void __init mem_init(void) > int arch_add_memory(u64 start, u64 size) > { > struct pglist_data *pgdata = &contig_page_data; > - struct zone *zone = pgdata->node_zones + MAX_NR_ZONES-1; > + struct zone *zone = pgdata->node_zones + > + zone_for_memory(nid, start, size, ZONE_HIGHMEM); > unsigned long start_pfn = start >> PAGE_SHIFT; > unsigned long nr_pages = size >> PAGE_SHIFT; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [119.145.14.64]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 058D81A01C2 for ; Tue, 22 Jul 2014 13:09:58 +1000 (EST) Message-ID: <53CDD5EE.1030805@huawei.com> Date: Tue, 22 Jul 2014 11:09:34 +0800 From: Wang Nan MIME-Version: 1.0 To: Andrew Morton Subject: Re: [PATCH v2 7/7] memory-hotplug: tile: suitable memory should go to ZONE_MOVABLE References: <1405914402-66212-1-git-send-email-wangnan0@huawei.com> <1405914402-66212-8-git-send-email-wangnan0@huawei.com> In-Reply-To: <1405914402-66212-8-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset="GB2312" Cc: Wang Nan , linux-ia64@vger.kernel.org, peifeiyue@huawei.com, linux-mm@kvack.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, Chris Metcalf , Dave Hansen , Ingo Molnar , Zhang Yanfei , Mel Gorman , Yinghai Lu List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Andrew, Please drop patch 7/7 from -mm tree and keep other 6 patches. arch_add_memory() in tile is different from others: no nid parameter. Patch 7/7 will block compiling. I cc this mail to Chris Metcalf and hope he can look at this issue. Other 6 patches looks good. On 2014/7/21 11:46, Wang Nan wrote: > This patch introduces zone_for_memory() to arch_add_memory() on tile to > ensure new, higher memory added into ZONE_MOVABLE if movable zone has > already setup. > > This patch also fix a problem: on tile, new memory should be added into > ZONE_HIGHMEM by default, not MAX_NR_ZONES-1, which is ZONE_MOVABLE. > > Signed-off-by: Wang Nan > Cc: Zhang Yanfei > Cc: Dave Hansen > --- > arch/tile/mm/init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/tile/mm/init.c b/arch/tile/mm/init.c > index bfb3127..22ac6c1 100644 > --- a/arch/tile/mm/init.c > +++ b/arch/tile/mm/init.c > @@ -872,7 +872,8 @@ void __init mem_init(void) > int arch_add_memory(u64 start, u64 size) > { > struct pglist_data *pgdata = &contig_page_data; > - struct zone *zone = pgdata->node_zones + MAX_NR_ZONES-1; > + struct zone *zone = pgdata->node_zones + > + zone_for_memory(nid, start, size, ZONE_HIGHMEM); > unsigned long start_pfn = start >> PAGE_SHIFT; > unsigned long nr_pages = size >> PAGE_SHIFT; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) by kanga.kvack.org (Postfix) with ESMTP id 2E7086B0035 for ; Mon, 21 Jul 2014 23:10:54 -0400 (EDT) Received: by mail-pd0-f169.google.com with SMTP id y10so10322949pdj.14 for ; Mon, 21 Jul 2014 20:10:53 -0700 (PDT) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com. [119.145.14.64]) by mx.google.com with ESMTPS id cl4si16117104pbb.175.2014.07.21.20.10.50 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 21 Jul 2014 20:10:53 -0700 (PDT) Message-ID: <53CDD5EE.1030805@huawei.com> Date: Tue, 22 Jul 2014 11:09:34 +0800 From: Wang Nan MIME-Version: 1.0 Subject: Re: [PATCH v2 7/7] memory-hotplug: tile: suitable memory should go to ZONE_MOVABLE References: <1405914402-66212-1-git-send-email-wangnan0@huawei.com> <1405914402-66212-8-git-send-email-wangnan0@huawei.com> In-Reply-To: <1405914402-66212-8-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Wang Nan , Ingo Molnar , Yinghai Lu , Mel Gorman , Dave Hansen , Zhang Yanfei , peifeiyue@huawei.com, linux-mm@kvack.org, x86@kernel.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Metcalf Hi Andrew, Please drop patch 7/7 from -mm tree and keep other 6 patches. arch_add_memory() in tile is different from others: no nid parameter. Patch 7/7 will block compiling. I cc this mail to Chris Metcalf and hope he can look at this issue. Other 6 patches looks good. On 2014/7/21 11:46, Wang Nan wrote: > This patch introduces zone_for_memory() to arch_add_memory() on tile to > ensure new, higher memory added into ZONE_MOVABLE if movable zone has > already setup. > > This patch also fix a problem: on tile, new memory should be added into > ZONE_HIGHMEM by default, not MAX_NR_ZONES-1, which is ZONE_MOVABLE. > > Signed-off-by: Wang Nan > Cc: Zhang Yanfei > Cc: Dave Hansen > --- > arch/tile/mm/init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/tile/mm/init.c b/arch/tile/mm/init.c > index bfb3127..22ac6c1 100644 > --- a/arch/tile/mm/init.c > +++ b/arch/tile/mm/init.c > @@ -872,7 +872,8 @@ void __init mem_init(void) > int arch_add_memory(u64 start, u64 size) > { > struct pglist_data *pgdata = &contig_page_data; > - struct zone *zone = pgdata->node_zones + MAX_NR_ZONES-1; > + struct zone *zone = pgdata->node_zones + > + zone_for_memory(nid, start, size, ZONE_HIGHMEM); > unsigned long start_pfn = start >> PAGE_SHIFT; > unsigned long nr_pages = size >> PAGE_SHIFT; > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752640AbaGVDKK (ORCPT ); Mon, 21 Jul 2014 23:10:10 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:62183 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbaGVDKI (ORCPT ); Mon, 21 Jul 2014 23:10:08 -0400 Message-ID: <53CDD5EE.1030805@huawei.com> Date: Tue, 22 Jul 2014 11:09:34 +0800 From: Wang Nan User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Andrew Morton CC: Wang Nan , Ingo Molnar , Yinghai Lu , Mel Gorman , Dave Hansen , Zhang Yanfei , , , , , , , , Chris Metcalf Subject: Re: [PATCH v2 7/7] memory-hotplug: tile: suitable memory should go to ZONE_MOVABLE References: <1405914402-66212-1-git-send-email-wangnan0@huawei.com> <1405914402-66212-8-git-send-email-wangnan0@huawei.com> In-Reply-To: <1405914402-66212-8-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.69.90] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, Please drop patch 7/7 from -mm tree and keep other 6 patches. arch_add_memory() in tile is different from others: no nid parameter. Patch 7/7 will block compiling. I cc this mail to Chris Metcalf and hope he can look at this issue. Other 6 patches looks good. On 2014/7/21 11:46, Wang Nan wrote: > This patch introduces zone_for_memory() to arch_add_memory() on tile to > ensure new, higher memory added into ZONE_MOVABLE if movable zone has > already setup. > > This patch also fix a problem: on tile, new memory should be added into > ZONE_HIGHMEM by default, not MAX_NR_ZONES-1, which is ZONE_MOVABLE. > > Signed-off-by: Wang Nan > Cc: Zhang Yanfei > Cc: Dave Hansen > --- > arch/tile/mm/init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/tile/mm/init.c b/arch/tile/mm/init.c > index bfb3127..22ac6c1 100644 > --- a/arch/tile/mm/init.c > +++ b/arch/tile/mm/init.c > @@ -872,7 +872,8 @@ void __init mem_init(void) > int arch_add_memory(u64 start, u64 size) > { > struct pglist_data *pgdata = &contig_page_data; > - struct zone *zone = pgdata->node_zones + MAX_NR_ZONES-1; > + struct zone *zone = pgdata->node_zones + > + zone_for_memory(nid, start, size, ZONE_HIGHMEM); > unsigned long start_pfn = start >> PAGE_SHIFT; > unsigned long nr_pages = size >> PAGE_SHIFT; > >