From: David Henningsson <david.henningsson@canonical.com>
To: mengdong.lin@intel.com, alsa-devel@alsa-project.org, tiwai@suse.de
Subject: Re: [PATCH] ALSA: hda - initialize audio InfoFrame to be all zero
Date: Tue, 22 Jul 2014 08:52:31 +0200 [thread overview]
Message-ID: <53CE0A2F.3070204@canonical.com> (raw)
In-Reply-To: <f37b3349bd0a4f5989cf503f578e25ad0f7d160e.1394572173.git.mengdong.lin@intel.com>
Hi,
It looks like this patch should have been sent to stable, is there any
reason why it wasn't?
On 2014-03-11 22:12, mengdong.lin@intel.com wrote:
> From: Mengdong Lin <mengdong.lin@intel.com>
>
> This patch initialized the local audio InfoFrame variable 'ai' to be all zero,
> thus the data bytes will indicate "Refer to Stream Header" by default.
>
> Signed-off-by: Mengdong Lin <mengdong.lin@intel.com>
>
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 5ef9503..3ab7063 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -1062,6 +1062,7 @@ static void hdmi_pin_setup_infoframe(struct hda_codec *codec,
> {
> union audio_infoframe ai;
>
> + memset(&ai, 0, sizeof(ai));
> if (conn_type == 0) { /* HDMI */
> struct hdmi_audio_infoframe *hdmi_ai = &ai.hdmi;
>
>
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
next prev parent reply other threads:[~2014-07-22 6:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 21:12 [PATCH] ALSA: hda - initialize audio InfoFrame to be all zero mengdong.lin
2014-03-11 8:16 ` Takashi Iwai
2014-07-22 6:52 ` David Henningsson [this message]
2014-07-22 7:01 ` [alsa-devel] " Takashi Iwai
2014-07-23 0:08 ` Greg KH
2014-07-23 10:19 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CE0A2F.3070204@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=mengdong.lin@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.