From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH 1/4] drm/dsi: Make mipi_dsi_dcs_write() return ssize_t Date: Tue, 22 Jul 2014 09:28:39 +0200 Message-ID: <53CE12A7.1010403@samsung.com> References: <1406013141-18552-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by gabe.freedesktop.org (Postfix) with ESMTP id BC0E36E4AF for ; Tue, 22 Jul 2014 00:29:40 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N9300FO1RGHYX20@mailout3.w1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 22 Jul 2014 08:29:05 +0100 (BST) In-reply-to: <1406013141-18552-1-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hi Thierry, Thanks for the patch. On 07/22/2014 09:12 AM, Thierry Reding wrote: > From: Thierry Reding > > This function returns the value of the struct mipi_dsi_host_ops' > .transfer() so make sure the return types are consistent. > > Signed-off-by: Thierry Reding Acked-by: Andrzej Hajda -- Regards Andrzej > --- > drivers/gpu/drm/drm_mipi_dsi.c | 4 ++-- > drivers/gpu/drm/panel/panel-s6e8aa0.c | 4 ++-- > include/drm/drm_mipi_dsi.h | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index e633df2f68d8..6d2fd2077dae 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -205,8 +205,8 @@ EXPORT_SYMBOL(mipi_dsi_detach); > * @data: pointer to the command followed by parameters > * @len: length of @data > */ > -int mipi_dsi_dcs_write(struct mipi_dsi_device *dsi, unsigned int channel, > - const void *data, size_t len) > +ssize_t mipi_dsi_dcs_write(struct mipi_dsi_device *dsi, unsigned int channel, > + const void *data, size_t len) > { > const struct mipi_dsi_host_ops *ops = dsi->host->ops; > struct mipi_dsi_msg msg = { > diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c b/drivers/gpu/drm/panel/panel-s6e8aa0.c > index 06e57a26db7a..beb43492b649 100644 > --- a/drivers/gpu/drm/panel/panel-s6e8aa0.c > +++ b/drivers/gpu/drm/panel/panel-s6e8aa0.c > @@ -133,14 +133,14 @@ static int s6e8aa0_clear_error(struct s6e8aa0 *ctx) > static void s6e8aa0_dcs_write(struct s6e8aa0 *ctx, const void *data, size_t len) > { > struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > - int ret; > + ssize_t ret; > > if (ctx->error < 0) > return; > > ret = mipi_dsi_dcs_write(dsi, dsi->channel, data, len); > if (ret < 0) { > - dev_err(ctx->dev, "error %d writing dcs seq: %*ph\n", ret, len, > + dev_err(ctx->dev, "error %zd writing dcs seq: %*ph\n", ret, len, > data); > ctx->error = ret; > } > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index efa1b552adc5..4b0112781910 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -127,8 +127,8 @@ struct mipi_dsi_device { > > int mipi_dsi_attach(struct mipi_dsi_device *dsi); > int mipi_dsi_detach(struct mipi_dsi_device *dsi); > -int mipi_dsi_dcs_write(struct mipi_dsi_device *dsi, unsigned int channel, > - const void *data, size_t len); > +ssize_t mipi_dsi_dcs_write(struct mipi_dsi_device *dsi, unsigned int channel, > + const void *data, size_t len); > ssize_t mipi_dsi_dcs_read(struct mipi_dsi_device *dsi, unsigned int channel, > u8 cmd, void *data, size_t len); >